fix(tui): show direct child sessions as subagents#29174
Open
ChamHerry wants to merge 2 commits into
Open
Conversation
Direct session.create(parentID) children need to appear in the TUI and run footer even when plugin orchestration does not create native task tool parts. Constraint: session.create(parentID) direct children have no persisted task tool part metadata. Rejected: routing OpenSDD through the task tool by default | it changes deterministic orchestration semantics. Confidence: high Scope-risk: moderate Directive: Keep native task metadata tabs authoritative when task parts exist for the same child session. Tested: bun test test/cli/run/subagent-data.test.ts test/cli/run/stream.transport.test.ts; bun test test/cli/run/footer.view.test.tsx test/cli/cmd/tui/sync.test.tsx test/cli/cmd/tui/sync-undefined-messages.test.tsx test/cli/tui/use-event.test.tsx test/server/httpapi-session.test.ts; bun test test/server/httpapi-sdk.test.ts test/server/session-list.test.ts; bun typecheck; bun run lint; prettier; git diff --check; live HTTP API smoke Not-tested: Manual interactive TUI visual smoke in a real user terminal
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29175
Type of change
What does this PR do?
Shows direct child sessions in the parent session UI when they were created with
session.create(parentID)instead of the nativetasktool.The fix teaches the run footer stream state to discover direct child sessions from bootstrap data and
session.created/session.updatedevents, then renders those children as subagent-style entries. Nativetaskmetadata still wins when it exists for the same child session.How did you verify your code works?
bun test test/cli/run/subagent-data.test.ts test/cli/run/stream.transport.test.tsbun test test/cli/run/footer.view.test.tsx test/cli/cmd/tui/sync.test.tsx test/cli/cmd/tui/sync-undefined-messages.test.tsx test/cli/tui/use-event.test.tsx test/server/httpapi-session.test.tsbun test test/server/httpapi-sdk.test.ts test/server/session-list.test.tsbun typecheckbun run lint(0 errors)git diff --checksession.createScreenshots / recordings
Not included. This is a terminal UI state fix covered by the tests above.
Checklist