fix(tui): show direct child sessions as subagents#1
Closed
ChamHerry wants to merge 1 commit into
Closed
Conversation
Direct session.create(parentID) children need to appear in the TUI and run footer even when plugin orchestration does not create native task tool parts. Constraint: session.create(parentID) direct children have no persisted task tool part metadata. Rejected: routing OpenSDD through the task tool by default | it changes deterministic orchestration semantics. Confidence: high Scope-risk: moderate Directive: Keep native task metadata tabs authoritative when task parts exist for the same child session. Tested: bun test test/cli/run/subagent-data.test.ts test/cli/run/stream.transport.test.ts; bun test test/cli/run/footer.view.test.tsx test/cli/cmd/tui/sync.test.tsx test/cli/cmd/tui/sync-undefined-messages.test.tsx test/cli/tui/use-event.test.tsx test/server/httpapi-session.test.ts; bun test test/server/httpapi-sdk.test.ts test/server/session-list.test.ts; bun typecheck; bun run lint; prettier; git diff --check; live HTTP API smoke Not-tested: Manual interactive TUI visual smoke in a real user terminal
Owner
Author
|
Closing this fork-internal draft PR because the intended target is the official upstream repository: anomalyco#29174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.create(parentID)child sessions inopencode runsubagent footer tabs even when no nativetasktool part exists.taskmetadata authoritative when a task-created subagent exists for the same child session.Why
OpenSDD/plugin orchestration can create child sessions directly through the session API. Those children were persisted and streamable, but the UI only discovered subagents from native
tasktool parts, so direct children were invisible in the parent session UI.Validation
bun test test/cli/run/subagent-data.test.ts test/cli/run/stream.transport.test.tsbun test test/cli/run/footer.view.test.tsx test/cli/cmd/tui/sync.test.tsx test/cli/cmd/tui/sync-undefined-messages.test.tsx test/cli/tui/use-event.test.tsx test/server/httpapi-session.test.tsbun test test/server/httpapi-sdk.test.ts test/server/session-list.test.tsbun typecheckbun run lint(3109 warnings / 0 errors, existing warning-only baseline)git diff --checksession.createNotes
tasktool by default.bun@^1.3.14while this shell hasbun@1.3.11; the branch was pushed withHUSKY=0after the checks above passed.