Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/remote-execution/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# https://github.com/puppeteer/puppeteer/blob/866addd132270e56cb1f84885f2897123087215c/docker/Dockerfile
FROM ghcr.io/puppeteer/puppeteer:24.39.1@sha256:56da7960d411f92a90dd7ea47b3b2092da58c15db399a974a3c58e0c8557bdc6
FROM ghcr.io/puppeteer/puppeteer:24.40.0@sha256:de1c985f0af848b07599cdb20ec0509b1a69927cf466b65cf56eb706cc4245fb

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This update to the base image is a necessary first step, but it's incomplete on its own. The remote build execution platform uses a pre-built image whose digest is pinned in bazel/remote-execution/BUILD.bazel. For this change to have any effect, the following steps are required:

  1. Rebuild this Docker image.
  2. Push the new image to the artifact registry (us-west2-docker.pkg.dev/...).
  3. Update the container-image sha256 digest in bazel/remote-execution/BUILD.bazel.

Without these follow-up actions, the remote builds will continue to use the old image, and this update will be ineffective.


# Switch back to `root` because Puppeteer sets up a non-root user in the
# image- preventing us from preparing Firefox dependencies.
Expand Down
Loading