Skip to content

build: update ghcr.io/puppeteer/puppeteer docker tag to v24.40.0#3563

Open
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/ghcr-io-puppeteer-puppeteer-24-x
Open

build: update ghcr.io/puppeteer/puppeteer docker tag to v24.40.0#3563
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/ghcr-io-puppeteer-puppeteer-24-x

Conversation

@angular-robot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
ghcr.io/puppeteer/puppeteer final minor 24.39.124.40.0

  • If you want to rebase/retry this PR, check this box

Release Notes

puppeteer/puppeteer (ghcr.io/puppeteer/puppeteer)

v24.40.0

♻️ Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 24.39.1 to 24.40.0
🎉 Features
  • support PUPPETEER_DANGEROUS_NO_SANDBOX environment variable (#​14756) (2a8276e)
🛠️ Fixes

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Mar 20, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the Puppeteer base image in the Dockerfile. My review includes a comment pointing out that this change is part of a larger process. For the update to take effect, the Docker image needs to be rebuilt and pushed, and the image digest in bazel/remote-execution/BUILD.bazel must be updated accordingly.

@@ -1,5 +1,5 @@
# https://github.com/puppeteer/puppeteer/blob/866addd132270e56cb1f84885f2897123087215c/docker/Dockerfile
FROM ghcr.io/puppeteer/puppeteer:24.39.1@sha256:56da7960d411f92a90dd7ea47b3b2092da58c15db399a974a3c58e0c8557bdc6
FROM ghcr.io/puppeteer/puppeteer:24.40.0@sha256:de1c985f0af848b07599cdb20ec0509b1a69927cf466b65cf56eb706cc4245fb

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This update to the base image is a necessary first step, but it's incomplete on its own. The remote build execution platform uses a pre-built image whose digest is pinned in bazel/remote-execution/BUILD.bazel. For this change to have any effect, the following steps are required:

  1. Rebuild this Docker image.
  2. Push the new image to the artifact registry (us-west2-docker.pkg.dev/...).
  3. Update the container-image sha256 digest in bazel/remote-execution/BUILD.bazel.

Without these follow-up actions, the remote builds will continue to use the old image, and this update will be ineffective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant