build: update ghcr.io/puppeteer/puppeteer docker tag to v24.40.0#3563
build: update ghcr.io/puppeteer/puppeteer docker tag to v24.40.0#3563angular-robot wants to merge 1 commit intoangular:mainfrom
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This PR updates the Puppeteer base image in the Dockerfile. My review includes a comment pointing out that this change is part of a larger process. For the update to take effect, the Docker image needs to be rebuilt and pushed, and the image digest in bazel/remote-execution/BUILD.bazel must be updated accordingly.
| @@ -1,5 +1,5 @@ | |||
| # https://github.com/puppeteer/puppeteer/blob/866addd132270e56cb1f84885f2897123087215c/docker/Dockerfile | |||
| FROM ghcr.io/puppeteer/puppeteer:24.39.1@sha256:56da7960d411f92a90dd7ea47b3b2092da58c15db399a974a3c58e0c8557bdc6 | |||
| FROM ghcr.io/puppeteer/puppeteer:24.40.0@sha256:de1c985f0af848b07599cdb20ec0509b1a69927cf466b65cf56eb706cc4245fb | |||
There was a problem hiding this comment.
This update to the base image is a necessary first step, but it's incomplete on its own. The remote build execution platform uses a pre-built image whose digest is pinned in bazel/remote-execution/BUILD.bazel. For this change to have any effect, the following steps are required:
- Rebuild this Docker image.
- Push the new image to the artifact registry (
us-west2-docker.pkg.dev/...). - Update the
container-imagesha256 digest inbazel/remote-execution/BUILD.bazel.
Without these follow-up actions, the remote builds will continue to use the old image, and this update will be ineffective.
This PR contains the following updates:
24.39.1→24.40.0Release Notes
puppeteer/puppeteer (ghcr.io/puppeteer/puppeteer)
v24.40.0♻️ Chores
Dependencies
🎉 Features
🛠️ Fixes