Merged
Conversation
hawkgs
force-pushed
the
drop-protractor
branch
from
42c9e3a to
27f9810
Compare
hawkgs
commented
Feb 24, 2026
Member
|
Can you also split this into two commits? |
hawkgs
force-pushed
the
drop-protractor
branch
from
27f9810 to
fb465eb
Compare
alan-agius4
added
the
action: review
alan-agius4
reviewed
Feb 25, 2026
alan-agius4
added
the
target: major
alan-agius4
reviewed
Feb 25, 2026
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
ts-node should also be removed as a dependencies in all package.json
alan-agius4
reviewed
Feb 25, 2026
clydin
reviewed
Feb 26, 2026
hawkgs
force-pushed
the
drop-protractor
branch
4 times, most recently
from
d2e2032 to
dacee85
Compare
hawkgs
added
action: cleanup
clydin
reviewed
Feb 26, 2026
Comment on lines
35
to
38
| "web-test-runner": { | ||
| "implementation": "./src/builders/web-test-runner", | ||
| "schema": "./src/builders/web-test-runner/schema.json", | ||
| "description": "Run unit tests with Web Test Runner." |
Member
There was a problem hiding this comment.
Looks like a merge conflict issue. This was recently removed.
Member
Author
There was a problem hiding this comment.
I had to rebase twice, so somehow it slipped through, I guess.
clydin
approved these changes
Feb 26, 2026
Member
|
Can you rebase? |
Protractor is no longer supported and has been deprecated since v19.
Remove Protractor since it's no longer supported and has been deprecated since v19; Remove the dependency.
hawkgs
force-pushed
the
drop-protractor
branch
from
b1b09fa to
a0be13f
Compare
Member
Author
|
Done. |
clydin
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Drop Protractor from the respository since it's no longer supported.
Does this PR introduce a breaking change?