Skip to content

Commit dacee85

Browse files
committed
refactor(@angular-devkit/build-angular): remove protractor
Remove Protractor since it's no longer supported and has been deprecated since v19; Remove the dependency.
1 parent 84cf1d9 commit dacee85

File tree

30 files changed

+11
-1523
lines changed

30 files changed

+11
-1523
lines changed

goldens/public-api/angular_devkit/build_angular/index.api.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,6 @@ export function executeKarmaBuilder(options: KarmaBuilderOptions, context: Build
173173
// @public
174174
export function executeNgPackagrBuilder(options: NgPackagrBuilderOptions, context: BuilderContext): Observable<BuilderOutput>;
175175

176-
// @public
177-
export function executeProtractorBuilder(options: ProtractorBuilderOptions, context: BuilderContext): Promise<BuilderOutput>;
178-
179176
// @public
180177
export function executeServerBuilder(options: ServerBuilderOptions, context: BuilderContext, transforms?: {
181178
webpackConfiguration?: ExecutionTransformer<webpack.Configuration>;
@@ -269,20 +266,6 @@ export enum OutputHashing {
269266
None = "none"
270267
}
271268

272-
// @public
273-
export type ProtractorBuilderOptions = {
274-
baseUrl?: string;
275-
devServerTarget?: string;
276-
grep?: string;
277-
host?: string;
278-
invertGrep?: boolean;
279-
port?: number;
280-
protractorConfig: string;
281-
specs?: string[];
282-
suite?: string;
283-
webdriverUpdate?: boolean;
284-
};
285-
286269
// @public (undocumented)
287270
export type ServerBuilderOptions = {
288271
assets?: AssetPattern_3[];

modules/testing/builder/projects/hello-world-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.
2020

2121
## Running end-to-end tests
2222

23-
Run `ng e2e` to execute the end-to-end tests via [Protractor](http://www.protractortest.org/).
23+
Run `ng e2e` to setup and run the end-to-end tests.
2424

2525
## Further help
2626

modules/testing/builder/projects/hello-world-app/angular.json

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -172,20 +172,6 @@
172172
}
173173
}
174174
}
175-
},
176-
"app-e2e": {
177-
"root": "e2e",
178-
"projectType": "application",
179-
"targets": {
180-
"e2e": {
181-
"builder": "@angular-devkit/build-angular:private-protractor",
182-
"options": {
183-
"protractorConfig": "protractor.conf.js",
184-
"devServerTarget": "app:serve",
185-
"webdriverUpdate": false
186-
}
187-
}
188-
}
189175
}
190176
}
191177
}

modules/testing/builder/projects/hello-world-app/e2e/app.e2e-spec.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

modules/testing/builder/projects/hello-world-app/e2e/app.po.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

modules/testing/builder/projects/hello-world-app/e2e/tsconfig.e2e.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

modules/testing/builder/projects/hello-world-app/protractor.conf.js

Lines changed: 0 additions & 43 deletions
This file was deleted.

modules/testing/builder/src/test-utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export const devServerTargetSpec = { project: 'app', target: 'serve' };
3636
export const extractI18nTargetSpec = { project: 'app', target: 'extract-i18n' };
3737
export const karmaTargetSpec = { project: 'app', target: 'test' };
3838
export const tslintTargetSpec = { project: 'app', target: 'lint' };
39-
export const protractorTargetSpec = { project: 'app-e2e', target: 'e2e' };
4039

4140
export async function createArchitect(workspaceRoot: Path) {
4241
const registry = new schema.CoreSchemaRegistry();

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@
118118
"lodash": "^4.17.21",
119119
"magic-string": "0.30.21",
120120
"prettier": "^3.0.0",
121-
"protractor": "~7.0.0",
122121
"puppeteer": "18.2.1",
123122
"quicktype-core": "23.2.6",
124123
"rollup": "4.59.0",
@@ -127,7 +126,6 @@
127126
"rollup-plugin-sourcemaps2": "0.5.6",
128127
"semver": "7.7.4",
129128
"source-map-support": "0.5.21",
130-
"ts-node": "^10.9.1",
131129
"tslib": "2.8.1",
132130
"typescript": "5.9.3",
133131
"undici": "7.22.0",

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ ts_json_schema(
4444
src = "src/builders/karma/schema.json",
4545
)
4646

47-
ts_json_schema(
48-
name = "protractor_schema",
49-
src = "src/builders/protractor/schema.json",
50-
)
51-
5247
ts_json_schema(
5348
name = "server_schema",
5449
src = "src/builders/server/schema.json",
@@ -109,7 +104,6 @@ ts_project(
109104
"//packages/angular_devkit/build_angular:src/builders/karma/schema.ts",
110105
"//packages/angular_devkit/build_angular:src/builders/ng-packagr/schema.ts",
111106
"//packages/angular_devkit/build_angular:src/builders/prerender/schema.ts",
112-
"//packages/angular_devkit/build_angular:src/builders/protractor/schema.ts",
113107
"//packages/angular_devkit/build_angular:src/builders/server/schema.ts",
114108
"//packages/angular_devkit/build_angular:src/builders/ssr-dev-server/schema.ts",
115109
],
@@ -321,18 +315,6 @@ LARGE_SPECS = {
321315
":node_modules/webpack",
322316
],
323317
},
324-
"protractor": {
325-
"extra_deps": [
326-
"//:node_modules/jasmine-spec-reporter",
327-
"//:node_modules/protractor",
328-
"//:node_modules/puppeteer",
329-
"//:node_modules/ts-node",
330-
],
331-
# NB: does not run on rbe because webdriver manager uses an absolute path to chromedriver
332-
"tags": ["no-remote-exec"],
333-
# NB: multiple shards will compete for port 4200 so limiting to 1
334-
"shards": 1,
335-
},
336318
"server": {
337319
"size": "large",
338320
"extra_deps": [

0 commit comments

Comments
 (0)