DX-1128: localise ProductTile + product data (leaf)#3414
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c57d361 to
eb5a063
Compare
70e3af1 to
99f78c8
Compare
eb5a063 to
6f2cac7
Compare
99f78c8 to
d9a67e2
Compare
6f2cac7 to
e11ceaf
Compare
d9a67e2 to
d53ff7f
Compare
e11ceaf to
f7308b7
Compare
d53ff7f to
52b61ec
Compare
f7308b7 to
b7b6074
Compare
52b61ec to
6f86900
Compare
6f86900 to
da88e2d
Compare
622c4dd to
8c73370
Compare
a4b57d4 to
ccb876a
Compare
8c73370 to
486571c
Compare
486571c to
94e7bcb
Compare
ccb876a to
22beed9
Compare
94e7bcb to
bb75ac0
Compare
22beed9 to
534866c
Compare
bb75ac0 to
0e10dee
Compare
534866c to
3f5ca9d
Compare
3f5ca9d to
f9dd330
Compare
0e10dee to
72f8545
Compare
f9dd330 to
573d680
Compare
573d680 to
5f29924
Compare
|
Where these are used (review aid):
~ 𝒞𝓁𝒶𝓊𝒹𝑒 |
kennethkalmer
left a comment
There was a problem hiding this comment.
Reviewed against @ably/ui source and docs' installed build — faithful vendoring.
- ProductTile/ProductIcon/ProductLabel/ProductDescription: formatting + import rewire only.
rightIconstring →<ArrowRightIcon>from@heroicons/react/16/solid(= old-micro, 16px), sized by thesize="xs"LinkButton slot (1rem). Dimension preserved. - ProductIcon still renders Ably product glyphs (
icon-product-*) through the local Icon — all vendored. - data.ts: the only content delta vs upstream is aiTransport's description, and it matches docs' installed
@ably/uibyte-for-byte ("Drop-in realtime continuity for Gen-2 AI experiences."). So no visual change; declining the newer upstream marketing copy is the right call, as the PR notes. - 5 caller import swaps (incl.
ProductNameinsrc/data/content/types.ts); no leftover@ably/ui/core/ProductTileimports.
Approving.
~ 𝒢𝓁𝒶𝓊𝒹𝑒
Part of DX-1128. Localises
ProductTile+ its product data (a leaf — copied per app).What
src/components/ui/ProductTile.tsx+ProductTile/(ProductIcon,ProductLabel,ProductDescription,data.ts). Product taxonomy data vendored locally.ProductIconkeeps rendering Ably's product glyphs through the localIcon— they're Ably-made glyphs, which is exactly what the glyphs-onlyIconhandles, so no icon-API change here.Behaviour
No visual change intended.
aiTransportcopy kept at the docs-installed wording (adopting newer marketing copy is a separate call).Stack (DX-1128)
@ably/uitokens + reset/core CSS (merged)cn+heightsutilsIconcomponent (Ably glyphs only; Heroicons imported directly)@ably/uiTailwind scan#3410–#3416 are a linear stack, each building on the previous; #3409 has merged to
main. ▶ = this PR.Testing
🤖 Generated with Claude Code