Skip to content

DX-1128: docs local design foundation (vendor @ably/ui tokens + reset CSS)#3409

Merged
jamiehenson merged 2 commits into
mainfrom
dx-1128/docs-local-design-foundation
Jun 23, 2026
Merged

DX-1128: docs local design foundation (vendor @ably/ui tokens + reset CSS)#3409
jamiehenson merged 2 commits into
mainfrom
dx-1128/docs-local-design-foundation

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128 / DXDR-005 (retire the shared @ably/ui package). Foundation PR — vendors @ably/ui's Tailwind theme + CSS into docs so the package is no longer the styling source.

What

  • Flattens @ably/ui's base Tailwind config into tailwind.config.js — the theme (colours, ui-text-* typography, screens, keyframes, plugins) is now inlined here instead of require('@ably/ui/tailwind.extend.js').
  • Vendors the reset + core + component CSS under src/styles/ui/ (properties.css token vars, text/buttons/forms/shadows/utils, reset/normalize, Code/Slider/Flash component CSS, syntax-highlighter). global.css @imports these locally.
  • Vendored tree added to .prettierignore.

Self-sufficiency

The node_modules/@ably/ui Tailwind content glob and the full vendored CSS are retained here, so this PR (and every PR up to #3415) is independently deployable — the still-present @ably/ui components in the early stack keep their utility classes. The dead-CSS prune + glob removal land in #3416 once everything is local.

Behaviour

No visual change intended. Theme verified equal to @ably/ui's extendConfig output; global.css compiles to ~8.4k lines with --color-*, ui-text-*, hljs all present.

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS
#3410 Local cn + heights utils
#3411 Docs-native Icon component
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan
#3417 Combined view of #3409#3416 — review/demo only (based on main)

#3409#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 800e831e-982e-4aef-a9d5-9d8aa6f4188d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-local-design-foundation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbue0k June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-local-design-foundation branch from 9793a26 to 53a85f2 Compare June 18, 2026 14:56
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbue0k June 18, 2026 14:57 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-local-design-foundation branch from 53a85f2 to 1b58cba Compare June 18, 2026 15:50
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbue0k June 18, 2026 15:50 Inactive
@jamiehenson jamiehenson marked this pull request as draft June 18, 2026 16:25
@jamiehenson jamiehenson added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--t31jel June 18, 2026 16:32 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--t31jel June 18, 2026 16:51 Inactive
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 17:04
@jamiehenson jamiehenson requested review from a team, kennethkalmer and matt423 and removed request for a team and matt423 June 18, 2026 17:04
@kennethkalmer

Copy link
Copy Markdown
Member

@jamiehenson did you manage to rebase this after #3418 got merged?

@kennethkalmer kennethkalmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraction makes sense, poked around the review app and everything looked okay 🎨

Vendor @ably/ui's Tailwind theme (inlined into tailwind.config.js) + reset/core/
component CSS under src/styles/ui/. Full CSS + the @ably/ui content glob retained
so each stacked PR stays self-sufficient; prune lands in the final PR.
@jamiehenson jamiehenson enabled auto-merge June 23, 2026 13:48
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--t31jel June 23, 2026 13:48 Inactive
@jamiehenson jamiehenson merged commit cc37d1e into main Jun 23, 2026
7 checks passed
@jamiehenson jamiehenson deleted the dx-1128/docs-local-design-foundation branch June 23, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants