Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .changeset/itchy-mirrors-yawn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@stackoverflow/stacks": minor
---

Remove deprecated components (breadcrumbs, button groups, cards, expandable, link previews, page titles, progress bars, topbar, uploader)
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { runA11yTests } from "../../test/a11y-test-utils";
import { html } from "@open-wc/testing";
import "../../index";

describe("breadcrumbs", () => {
describe.skip("breadcrumbs", () => {
runA11yTests({
baseClass: "s-breadcrumbs",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { runVisualTests } from "../../test/visual-test-utils";
import { html } from "@open-wc/testing";
import "../../index";

describe("breadcrumbs", () => {
describe.skip("breadcrumbs", () => {
runVisualTests({
baseClass: "s-breadcrumbs",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { testArgs } from "./button-group.test.setup";
import { runA11yTests } from "../../test/a11y-test-utils";
import "../../index";

describe("button group", () => {
describe.skip("button group", () => {
runA11yTests({
...testArgs,
// TODO remove skipped tests once btn badge contrast issues are resolved
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ import { testArgs } from "./button-group.test.setup";
import { runVisualTests } from "../../test/visual-test-utils";
import "../../index";

describe("button group", () => {
describe.skip("button group", () => {
runVisualTests(testArgs);
});
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { runA11yTests } from "../../test/a11y-test-utils";
import "../../index";

describe("card", () => {
describe.skip("card", () => {
runA11yTests({
baseClass: "s-card",
variants: ["muted"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const baseChild = `
</div>
`;

describe("card", () => {
describe.skip("card", () => {
runVisualTests({
baseClass: "s-card",
variants: ["muted"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { html } from "@open-wc/testing";
import { runA11yTests } from "../../test/a11y-test-utils";
import "../../index";

describe("expandable", () => {
describe.skip("expandable", () => {
runA11yTests({
baseClass: "s-expandable",
modifiers: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import "../../index";

const user = userEvent.setup();

describe("expandable-control", () => {
describe.skip("expandable-control", () => {
it("should focus on expandable content only when expanded", async () => {
await fixture(html`
<button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { html } from "@open-wc/testing";
import { runVisualTests } from "../../test/visual-test-utils";
import "../../index";

describe("expandable", () => {
describe.skip("expandable", () => {
runVisualTests({
baseClass: "s-expandable",
modifiers: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const getChild = (child?: string): string => {
</div>
`;
};
describe("link preview", () => {
describe.skip("link preview", () => {
runA11yTests({
baseClass: "s-link-preview",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const getChild = (child?: string): string => {
`;
};

describe("link preview", () => {
describe.skip("link preview", () => {
runVisualTests({
baseClass: "s-link-preview",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { html } from "@open-wc/testing";
import { runA11yTests } from "../../test/a11y-test-utils";
import "../../index";

describe("page title", () => {
describe.skip("page title", () => {
runA11yTests({
baseClass: "s-page-title",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const getChildren = ({
}
`;

describe("page title", () => {
describe.skip("page title", () => {
runVisualTests({
baseClass: "s-page-title",
children: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const getChildren = (type: string) => {
return `<div class="s-progress--bar" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="75" aria-label="progress" style="width: 75%"></div>`;
}
};
describe("progress-bar", () => {
describe.skip("progress-bar", () => {
// Base
runA11yTests({
baseClass: "s-progress",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const getChildren = (type: string) => {
return `<div class="s-progress--bar" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="75" aria-label="progress" style="width: 75%"></div>`;
}
};
describe("progress-bar", () => {
describe.skip("progress-bar", () => {
// Base
runVisualTests({
baseClass: "s-progress",
Expand Down
10 changes: 0 additions & 10 deletions packages/stacks-classic/lib/components/table/table.visual.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ const children = {
<th scope="col">Display Name</th>
<th scope="col">Full name</th>
<th scope="col" colspan="2">Progress</th>
<th scope="col"><span>class="v-visible-sr">Bar</span></th>
</tr>
</thead>
<tbody>
Expand All @@ -64,15 +63,6 @@ const children = {
<td>${row.displayName}</td>
<td>${row.fullName}</td>
<td class="s-table--progress">${row.progress}</td>
<td class="s-table--progress-bar">
<div class="s-progress bg-white">
<div class="s-progress--bar bg-blue-400" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="${
row.progress
}" aria-label="progressbar" style="width: ${
row.progress
}%"></div>
</div>
</td>
<td><a class="s-link" href="#">Add</a></td>
</tr>
`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ const topbars = {
}),
};

describe("topbar", () => {
describe.skip("topbar", () => {
runVisualTests({
baseClass: "s-topbar",
tag: "header",
Expand Down
2 changes: 0 additions & 2 deletions packages/stacks-classic/lib/controllers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export {
hideBanner,
showBanner,
} from "./components/banner/banner";
export { ExpandableController } from "./components/expandable/expandable";
export {
ModalController,
hideModal,
Expand All @@ -30,4 +29,3 @@ export {
setTooltipText,
TooltipController,
} from "./components/popover/tooltip";
export { UploaderController } from "./components/uploader/uploader";
4 changes: 0 additions & 4 deletions packages/stacks-classic/lib/index.ts
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
import "./stacks.less";
import {
BannerController,
ExpandableController,
ModalController,
PopoverController,
TableController,
TabListController,
ToastController,
TooltipController,
UploaderController,
} from "./controllers";
import { application, StacksApplication } from "./stacks";

// register all built-in controllers
application.register("s-banner", BannerController);
application.register("s-expandable-control", ExpandableController);
application.register("s-modal", ModalController);
application.register("s-toast", ToastController);
application.register("s-navigation-tablist", TabListController);
application.register("s-popover", PopoverController);
application.register("s-table", TableController);
application.register("s-tooltip", TooltipController);
application.register("s-uploader", UploaderController);

// finalize the application to guard our controller namespace
StacksApplication.finalize();
Expand Down
11 changes: 1 addition & 10 deletions packages/stacks-classic/lib/stacks-static.less
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part I care the most about.

Original file line number Diff line number Diff line change
Expand Up @@ -51,43 +51,34 @@
@import "components/badge/badge.less";
@import "components/banner/banner.less";
@import "components/bling/bling.less";
@import "components/breadcrumbs/breadcrumbs.less";
@import "components/button/button.less";
@import "components/button-group/button-group.less";
@import "components/card/card.less";
@import "components/checkbox_radio/checkbox_radio.less";
@import "components/form-group/form-group.less";
@import "components/code-block/code-block.less";
@import "components/description/description.less";
@import "components/empty-state/empty-state.less";
@import "components/expandable/expandable.less";
@import "components/input_textarea/input_textarea.less";
@import "components/input-fill/input-fill.less";
@import "components/input-icon/input-icon.less";
@import "components/input-message/input-message.less";
@import "components/label/label.less";
@import "components/link/link.less";
@import "components/link-preview/link-preview.less";
@import "components/loader/loader.less";
@import "components/menu/menu.less";
@import "components/modal/modal.less";
@import "components/navigation/navigation.less";
@import "components/notice/notice.less";
@import "components/page-title/page-title.less";
@import "components/pagination/pagination.less";
@import "components/popover/popover.less";
@import "components/post-summary/post-summary.less";
@import "components/progress-bar/progress-bar.less";
@import "components/prose/prose.less";
@import "components/select/select.less";
@import "components/sidebar-widget/sidebar-widget.less";
@import "components/loader/loader.less";
@import "components/table/table.less";
@import "components/table-container/table-container.less";
@import "components/tag/tag.less";
@import "components/toast/toast.less";
@import "components/toggle-switch/toggle-switch.less";
@import "components/topbar/topbar.less";
@import "components/uploader/uploader.less";
@import "components/user-card/user-card.less";
@import "components/vote/vote.less";

Expand Down
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Git LFS file not shown
Loading