chore(components): remove deprecated components#2187
Conversation
🦋 Changeset detectedLatest commit: 6a63589 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks @dancormier.
This looks like a solid start! To keep this PR focused and cut a new release for our beta env, let’s handle the documentation updates and the removal of dead code and tests in a dedicated follow-up.
I’m a big advocate for keeping the codebase lean. We should feel confident deleting cruft knowing that git history is our safety net if we ever need to reference or restore that logic later.
NIT: On the empty pages, could we update the warning text from 'deprecated' to 'removed'? Since these components are no longer functional in v3, 'removed' gives our users more clarity on the current state of the API.
NIT: The uploader component has a stacks.js controller that should be removed/deleted from the bundle.
There was a problem hiding this comment.
This is the part I care the most about.
There was a problem hiding this comment.
Visually work for me! I'm not sure if this was intentional but the link to the v2 docs in the yellow notice from any of the deprecated components leads to Breadcrumbs. We could just default to the product landing page instead if we syncing up each component to the right page is too much work. (Card should point to v2 card page, Page title should point to v2 page title...)
This PR:
Screenshot
Note
I left the right rail table of contents in tact for these pages since it seemed like a bit of a lift to hide them without causing issues on rendering them on non-deprecated component pages when navigating around.
Note
I've left the visual regression test images in place but can remove them if you feel it's necessary @giamir. Just let me know