Skip to content

Comments

chore(components): remove deprecated components#2187

Merged
dancormier merged 9 commits intobetafrom
dcormier/rm-deprecated-components
Feb 20, 2026
Merged

chore(components): remove deprecated components#2187
dancormier merged 9 commits intobetafrom
dcormier/rm-deprecated-components

Conversation

@dancormier
Copy link
Contributor

@dancormier dancormier commented Feb 19, 2026

This PR:

  • Removes deprecated components from our CSS bundle
  • Adds a deprecation notice to the top of the docs pages for deprecated components with a link to v2 docs
  • Hides deprecated component docs page content

Screenshot

image

Note

I left the right rail table of contents in tact for these pages since it seemed like a bit of a lift to hide them without causing issues on rendering them on non-deprecated component pages when navigating around.

Note

I've left the visual regression test images in place but can remove them if you feel it's necessary @giamir. Just let me know

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 6a63589

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 6a63589
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6998e2d1f1b2ae000812e160
😎 Deploy Preview https://deploy-preview-2187--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 6a63589
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6998e2d19b91030008121b8c
😎 Deploy Preview https://deploy-preview-2187--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dancormier.

This looks like a solid start! To keep this PR focused and cut a new release for our beta env, let’s handle the documentation updates and the removal of dead code and tests in a dedicated follow-up.

I’m a big advocate for keeping the codebase lean. We should feel confident deleting cruft knowing that git history is our safety net if we ever need to reference or restore that logic later.

NIT: On the empty pages, could we update the warning text from 'deprecated' to 'removed'? Since these components are no longer functional in v3, 'removed' gives our users more clarity on the current state of the API.

NIT: The uploader component has a stacks.js controller that should be removed/deleted from the bundle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part I care the most about.

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually work for me! I'm not sure if this was intentional but the link to the v2 docs in the yellow notice from any of the deprecated components leads to Breadcrumbs. We could just default to the product landing page instead if we syncing up each component to the right page is too much work. (Card should point to v2 card page, Page title should point to v2 page title...)

@dancormier dancormier requested a review from CGuindon February 20, 2026 22:41
@dancormier
Copy link
Contributor Author

Nice catch @CGuindon! I've updated the link and I'm gonna go ahead and merge so we can cut a new release first thing Monday.

@giamir early next week, I'll put together a follow up PR removing all the cruft.

Thanks for the reviews!

@dancormier dancormier enabled auto-merge (squash) February 20, 2026 22:43
@dancormier dancormier merged commit 34a2cd1 into beta Feb 20, 2026
19 checks passed
@dancormier dancormier deleted the dcormier/rm-deprecated-components branch February 20, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants