Skip to content

Wire up React Native CI workflows#55

Merged
Juanita-Dash merged 1 commit into
mainfrom
rn-ci-wiring
May 11, 2026
Merged

Wire up React Native CI workflows#55
Juanita-Dash merged 1 commit into
mainfrom
rn-ci-wiring

Conversation

@Juanita-Dash
Copy link
Copy Markdown
Contributor

@Juanita-Dash Juanita-Dash commented May 11, 2026

Fixes https://github.com/shop/issues-checkout-kit/issues/907

Wires up React Native CI in the monorepo so PRs touching platforms/react-native/** get the same automated signal that platforms/android/** and platforms/swift/** already do. Mirrors the source repo's ci.yml and follows the existing android-* / swift-* patterns in this repo.

What's added

Six reusable workflows (rn-lint, rn-test, rn-test-android, rn-test-ios, rn-license-headers, rn-check-packed-files), wired into ci.yml's paths filter and ci-required aggregator. Plus four dependabot.yml entries (npm × 3 + bundler) for the RN tree.

Note: one-line .gitignore exception for iOS entitlements

Added !platforms/react-native/sample/ios/ReactNative/ReactNative.entitlements to the root .gitignore. The file was silently dropped during PR #31's verbatim import because the monorepo's **/*.entitlements rule excluded it. It's source code (associated domains + Apple Pay merchant ID), not a secret — Xcode requires it at build time and rn-test-ios fails without it.

Scope: build + test only

Publish (rn-deploy.yml) is a follow-up PR. Blocked on: monorepo tag-naming convention for RN releases, authorizing this repo to publish the npm package (currently only the source repo is), and coordinating the cutover from the source repo's publish workflow. Final package name also depends on #27 landing.

🤖 Generated with Claude Code

@shopify-bumperbot
Copy link
Copy Markdown

shopify-bumperbot Bot commented May 11, 2026

🔍 Denylist Analysis Results

Analyzed 2 packages.

.github/workflows/rn-test.yml


Known Packages - Approved for Use (2)
Package Version Details
MishaKav/jest-coverage-comment fb83bcbaeb5ca467936175796f862a2992938833 Package policy allows this version
actions/checkout de0fac2e4500dabe0009e67214ff5f5447ce83dd Package policy allows this version

For any questions or to provide feedback, please reach out to #help-bumperbot.

Generated by Bumperbot.

@Juanita-Dash Juanita-Dash force-pushed the rn-ci-wiring branch 3 times, most recently from b6d630a to e3ea5d0 Compare May 11, 2026 14:57
@Juanita-Dash Juanita-Dash requested review from a team, kiftio and markmur and removed request for kiftio May 11, 2026 15:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.53% (214/215) 95.96% (119/124) 100% (64/64)

@Juanita-Dash Juanita-Dash force-pushed the rn-ci-wiring branch 2 times, most recently from fbd9a03 to 1429ee9 Compare May 11, 2026 16:03
Adds six rn-*.yml reusable workflows under .github/workflows/, mirroring
the source repo's CI surface and following the existing android-*/swift-*
monorepo conventions (em-dash names, pinned action SHAs, workflow_call +
workflow_dispatch triggers, working-directory: platforms/react-native,
shop/setup-javascript-action for the JS toolchain).

Jobs (ordered "tests first, lint last" to match the swift section):
  - rn-test           jest (with coverage comment on PRs)
  - rn-test-android   pnpm sample test:android (JDK 22 / Gradle)
  - rn-test-ios       pnpm sample test:ios (vars.MACOS_RUNNER + cocoapods)
  - rn-license-headers ./scripts/copy_license --check
  - rn-check-packed-files module build + compare-snapshot
  - rn-lint           SwiftLint + module build + module/sample eslint

ci.yml: wires each new workflow into the orchestrator, extends the
reactNative paths filter to watch the new files, and adds them to
ci-required.needs so they participate in the aggregated status check.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@markmur markmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go once CI is passing

@Juanita-Dash Juanita-Dash requested review from a team and kyle-schellen May 11, 2026 16:56
Copy link
Copy Markdown
Contributor

@kyle-schellen kyle-schellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@Juanita-Dash Juanita-Dash merged commit 7a9643b into main May 11, 2026
39 of 41 checks passed
@Juanita-Dash Juanita-Dash deleted the rn-ci-wiring branch May 11, 2026 17:21
@Juanita-Dash Juanita-Dash self-assigned this May 11, 2026
@Juanita-Dash Juanita-Dash added the #gsd:50662 Rebase Checkout Kit on UCP label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants