Rename Checkout Sheet Kit to Checkout Kit (React Native)#27
Conversation
e08040b to
9582bbb
Compare
🔍 Denylist Analysis ResultsDiscovered 1075 packages. These include both those that are net-new and those that have been explicitly approved or denied for use. react-native/pnpm-lock.yaml❌ Known Packages - Denied for Use (1) - WILL BLOCK CI
🔄 New Packages Entering the Supply Chain (54)
✅ Known Packages - Approved for Use (969)
react-native/sample/Gemfile.lock✅ Known Packages - Approved for Use (46)
react-native/sample/package.json✅ Known Packages - Approved for Use (4)
react-native/sample/ios/ReactNative.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved✅ Known Packages - Approved for Use (1)
For any questions or to provide feedback, please reach out to #help-bumperbot. Generated by Bumperbot. |
9582bbb to
b823e1c
Compare
00112e2 to
b82a603
Compare
b823e1c to
4cebcb7
Compare
b82a603 to
762a09c
Compare
4cebcb7 to
d7b45ee
Compare
762a09c to
e7c2c9c
Compare
d7b45ee to
b9bba7a
Compare
b9bba7a to
47e2aa4
Compare
47e2aa4 to
8e6615d
Compare
| PRODUCT_BUNDLE_IDENTIFIER = com.shopify.example.CheckoutKitReactNative; | ||
| PRODUCT_NAME = "$(TARGET_NAME)"; | ||
| SWIFT_INCLUDE_PATHS = "$(inherited) \"${PODS_CONFIGURATION_BUILD_DIR}/ShopifyCheckoutSheetKit\" \"${PODS_CONFIGURATION_BUILD_DIR}/YogaKit\" \"${PODS_CONFIGURATION_BUILD_DIR}/RNShopifyCheckoutSheetKit\"/**"; | ||
| SWIFT_INCLUDE_PATHS = "$(inherited) \"${PODS_CONFIGURATION_BUILD_DIR}/ShopifyCheckoutSheetKit\" \"${PODS_CONFIGURATION_BUILD_DIR}/YogaKit\" \"${PODS_CONFIGURATION_BUILD_DIR}/RNShopifyCheckoutKit\"/**"; |
There was a problem hiding this comment.
The two names on this line are intentional: ShopifyCheckoutSheetKit is the upstream Swift SDK pod (not yet republished under the new name, see the "NOT renamed (follow-up PRs)" section in the description), while RNShopifyCheckoutKit is the RN bridge pod defined in this repo, which is renamed here. They'll line up once the new Swift artifact ships
8e6615d to
2eaacd8
Compare
2eaacd8 to
2838549
Compare
2838549 to
59665be
Compare
|
PR #68 to replace shop/setup-javascript-action with local composite once shipped should address CI failures. |
59665be to
7183e13
Compare
| import SwiftUI | ||
| @testable import RNShopifyCheckoutSheetKit | ||
| @testable import RNShopifyCheckoutKit | ||
| @testable import ShopifyCheckoutSheetKit |
There was a problem hiding this comment.
which one is this referencing?
There was a problem hiding this comment.
That's the upstream native Swift SDK pod that's kept on the old name until it's republished. Same pattern as the pbxproj line (see here). The RN bridge import is the line above.
| import Foundation | ||
| @testable import RNShopifyCheckoutSheetKit | ||
| @testable import RNShopifyCheckoutKit | ||
| @testable import ShopifyCheckoutSheetKit |
There was a problem hiding this comment.
Same as above; upstream Swift SDK pod, kept on the old name until republished.
Renames the React Native bridge in react-native/ from Shopify Checkout Sheet Kit to Shopify Checkout Kit. Mirrors the parallel rename in the source repo (Shopify/checkout-sheet-kit-react-native#483) applied to the v4.0.0 import (#31). Stacked on rn-import-source-v4 (PR #31). When #31 merges, this will be auto-retargeted onto main with the rename diff intact. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7183e13 to
e2fde03
Compare
Renames the React Native bridge in
platforms/react-native/from Shopify Checkout Sheet Kit to Shopify Checkout Kit.Per the naming convention thread, the npm package uses a
-react-nativesuffix to disambiguate from the future web package (Option B).What's renamed
@shopify/checkout-sheet-kit→@shopify/checkout-kit-react-nativeRNShopifyCheckoutSheetKit→RNShopifyCheckoutKitcom.shopify.reactnative.checkoutsheetkit→com.shopify.reactnative.checkoutkitRNShopifyCheckoutSheetKitSpec→RNShopifyCheckoutKitSpecShopifyCheckoutSheet→ShopifyCheckout,ShopifyCheckoutSheetProvider→ShopifyCheckoutProvider,useShopifyCheckoutSheet→useShopifyCheckout,ShopifyCheckoutSheetContext→ShopifyCheckoutContextmodules/@shopify/checkout-sheet-kit/→modules/@shopify/checkout-kit-react-native/, allShopifyCheckoutSheetKit*files renamedWhat's intentionally NOT renamed (follow-up PRs)
Upstream native deps stay on the old names because the new artifacts haven't been published yet:
ShopifyCheckoutSheetKitcom.shopify:checkout-sheet-kitimport ShopifyCheckoutSheetKit+ framework callscom.shopify.checkoutsheetkit.*+ framework callsproguard-rules.prokeep ruleLog.etags inCustomCheckoutEventProcessor.java(mirrored from upstream)Deep-links in README / docs / podspec — follow the same anticipatory pattern as Swift + Android rename PRs; coordinated cross-platform follow-up when the monorepo goes public.
What's intentionally NOT changed (cross-team contracts)
ShopifyCheckoutSDK/<version>user-agent string (web checkout parses)window.MobileCheckoutSdkJS bridge global (web checkout defines)checkout-sdk.myshopify.comtest fixture URLs (not branding)Verification
CI is green. Local checks on the rebased branch:
pnpm module lint✅pnpm sample lint✅ (1 pre-existing inline-style warning, unrelated)pnpm test✅ 121/121 across 6 suitesNote
Rebased 2026-05-12 onto
main(post-#66) and updated to reflect the Option B npm naming convention. Package name is now@shopify/checkout-kit-react-nativeand the module directory was renamed to match.