-
Notifications
You must be signed in to change notification settings - Fork 229
[AgentX] vLLM DeepSeek-V4 B200 aggregate / vLLM DeepSeek-V4 B200 聚合配置 #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
3
commits into
main
Choose a base branch
from
agent/split-pr-2202-b200
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−42
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Line 2 changed
set -euo pipefailtoset -eo pipefail, dropping nounset — this is the only script among all 24 inbenchmarks/single_node/agentic/that doesn't use-u. The rewrite replaced every${VAR:-default}-guarded reference ($DCP_SIZE, $SLURM_JOB_ID, $SLURMD_NODENAME, $MODEL_PATH, $KV_OFFLOAD_BACKEND) with bare $VAR forms, which is why-uhad to go; the near-identicaldsv4_fp4_b300_vllm.shshows the same optional-var pattern works fine with-ukept and${VAR:-}guards. Recommend restoringset -euo pipefailand guarding the new bare references, to keep this script's safety net consistent with its siblings.Extended reasoning...
The bug: Line 2 of
dsv4_fp4_b200_vllm.shwas changed fromset -euo pipefailtoset -eo pipefail, silently dropping thenounset(-u) flag. Every other script inbenchmarks/single_node/agentic/— including the near-identicaldsv4_fp4_b300_vllm.sh, plusdsv4_fp4_mi355x_vllm.sh,dsv4_fp4_b200_sglang.sh,dsv4_fp8_h200.sh, and all thekimik2.5_*/qwen3.5_*/minimaxm3_*variants — still usesset -euo pipefail. This script is now the sole outlier in the directory.\n\nWhy it happened: The diff rewrote several previously-guarded optional-variable references into bare, unguarded forms:DCP_SIZE=${DCP_SIZE:-1}became anif [ -z "$DCP_SIZE" ]; then DCP_SIZE=1; fiblock (which still reads the bare$DCP_SIZEfirst),${SLURM_JOB_ID:-}/${SLURMD_NODENAME:-unknown}became bare$SLURM_JOB_ID/$SLURMD_NODENAME,${MODEL_PATH:-}became bare$MODEL_PATH, and the newcase "$KV_OFFLOAD_BACKEND" in "")branch reads$KV_OFFLOAD_BACKENDunguarded (note it isn't even part ofcheck_env_vars, so it can legitimately be unset). None of these would surviveset -uif the variable is genuinely unset, so-uhad to be dropped to make the rewritten code work as written.\n\nWhy this is avoidable: The siblingdsv4_fp4_b300_vllm.shproves-uand this exact optional-variable pattern coexist fine: it keepsset -euo pipefailwhile usingDCP_SIZE="${DCP_SIZE:-1}",declare -p SLURM_JOB_ID >/dev/null 2>&1 && [ -n "$SLURM_JOB_ID" ], and similar guards forMODEL_PATH. The newcasestatement here could equally have matched on"${KV_OFFLOAD_BACKEND:-}"instead of the bare variable. So dropping-uwasn't required by the case-statement refactor — it was a side effect of un-guarding several other references at the same time.\n\nImpact: With-udisabled, a future typo in a variable name anywhere in this script (e.g.RESULT_DIRmisspelled asRESUT_DIR) will silently expand to an empty string and continue executing rather than aborting immediately with an "unbound variable" error — exactly the failure mode-uexists to catch. As written today the script runs correctly (all currently-referenced optional vars are handled, and required vars are separately validated bycheck_env_vars), so there's no concrete runtime failure right now. This is a latent robustness/consistency regression rather than an active bug.\n\nProof by example: Suppose a future edit addsecho "Writing to $RESUT_DIR"(a typo of $RESULT_DIR) somewhere in this script. Withset -eo pipefail(current state), $RESUT_DIR expands to "", the echo prints "Writing to ", and the script continues — the typo goes unnoticed until output is inspected downstream. Withset -euo pipefail(every sibling script's setting), the same line would immediately abort withRESUT_DIR: unbound variable, catching the bug at the point of introduction. This is precisely why the convention exists across all 23 other scripts in the directory.\n\nFix: Restoreset -euo pipefailon line 2 and guard the newly-unguarded references the same waydsv4_fp4_b300_vllm.shdoes:DCP_SIZE="${DCP_SIZE:-1}"/PCP_SIZE="${PCP_SIZE:-1}",[[ -n "${SLURM_JOB_ID:-}" ]]/${SLURMD_NODENAME:-unknown},[[ -n "${MODEL_PATH:-}" ]], andcase "${KV_OFFLOAD_BACKEND:-}" in.