Skip to content

Enforce max 8 favorites and unfavorite non-runnable objectives#516

Merged
JWhitleyWork merged 1 commit intomainfrom
fix/unfavorite-non-runnable-objectives
Feb 24, 2026
Merged

Enforce max 8 favorites and unfavorite non-runnable objectives#516
JWhitleyWork merged 1 commit intomainfrom
fix/unfavorite-non-runnable-objectives

Conversation

@davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Feb 21, 2026

Summary

Cleans up Objective favorite metadata across all config packages to prepare for CI enforcement of favorite limits.

  • Added _favorite attribute to all objectives that were missing it, explicitly setting them to false for consistency
  • Unfavorited non-runnable objectives — objectives with <Metadata runnable="false"/> should never be favorites since they can't be executed directly
  • Unfavorited MPC Pose Tracking objectives (3) and ML Segment objectives (2) to reduce favorite count
  • Ran Prettier XML formatting on all modified files to ensure consistent formatting

These changes are required for the new CI check in #517, which enforces:

  1. Non-runnable objectives must not be favorited
  2. A maximum of 8 favorited objectives per config package — if everything is favorited, nothing is favorited

The end result is lab_sim has these favorites:
image

Test plan

🤖 Generated with Claude Code

@davetcoleman davetcoleman added this to the 9.1.0 milestone Feb 22, 2026
@davetcoleman davetcoleman changed the base branch from v9.0 to main February 24, 2026 16:57
@davetcoleman davetcoleman force-pushed the fix/unfavorite-non-runnable-objectives branch 3 times, most recently from 4aaa91d to 3facde2 Compare February 24, 2026 17:04
Objectives with runnable="false" metadata should not be marked as
favorites since they cannot be executed directly by users.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@davetcoleman davetcoleman force-pushed the fix/unfavorite-non-runnable-objectives branch from 3facde2 to dda30a3 Compare February 24, 2026 17:06
@davetcoleman davetcoleman changed the title Unfavorite non-runnable objectives Enforce max 8 favorites and unfavorite non-runnable objectives Feb 24, 2026
@JWhitleyWork JWhitleyWork merged commit 6a1c79a into main Feb 24, 2026
5 checks passed
@JWhitleyWork JWhitleyWork deleted the fix/unfavorite-non-runnable-objectives branch February 24, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants