Ares Optional Fix -- Ability To Revert Ares Transport Cloak Behavior

[CnCRAZER]

This pull request introduces a fix and new customization for the decloaking behavior of open-topped transports, specifically when passengers fire weapons with DecloakToFire=yes. The changes allow modders to control whether passenger actions can decloak their transporter, and revert a previous patch that forced decloaking under certain conditions.

Open-topped transport decloak behavior improvements:

• Added the OpenTopped.DecloakToFire option to both RulesExt and TechnoTypeExt, allowing global or per-unit control over whether passengers firing with DecloakToFire=yes decloak their open-topped transporter.

[github-actions]

Nightly build for this pull request:

• compiled-dll-8258346e0cb5ddd56800bcf452d9559842e02595.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

we don't need to simply revert, we need to have the behavior configurable between "uncloak transport on firing" and "don't uncloak on firing". as much as it may be desirable for CnCNet YR, the vanilla behavior is a bug, so we have to offer a fix with a possibility to revert (for CnCNet YR)

[NetsuNegi]

DEFINE_HOOK(0x6FCD1D, TechnoClass_CanFire_OpenTopCloakFix, 0x5) you did nothing here, why you hook on this address

[CnCRAZER]

DEFINE_HOOK(0x6FCD1D, TechnoClass_CanFire_OpenTopCloakFix, 0x5) you did nothing here, why you hook on this address

I didn't do anything is 100% correct. I took @MortonPL and deleted the part that didn't make it act like vanilla. If I need to delete it please tell me, I'm complete noob in this

[DeathFishAtEase]

The document is incomplete. Please complete it in the OpenTopped extension section, or if you don't mind, I might directly submit the changes (since I see you have checked Maintainers are allowed to edit this pull request.)

[CnCRAZER]

The document is incomplete. Please complete it in the OpenTopped extension section, or if you don't mind, I might directly submit the changes (since I see you have checked Maintainers are allowed to edit this pull request.)

There's an open topped extension section? Jesus Christ

[DeathFishAtEase]

There's an open topped extension section? Jesus Christ

See the section Customizable OpenTopped properties in the documentation.

This title corresponds to line 1552 of .\docs\New-or-Enhanced-Logics.md in the branch where the PR is located.

[CnCRAZER]

The document is incomplete. Please complete it in the OpenTopped extension section, or if you don't mind, I might directly submit the changes (since I see you have checked Maintainers are allowed to edit this pull request.)

Once I get the patch working in an acceptable manner I will go back and update the documentation. Thank you

[CnCRAZER]

DEFINE_HOOK(0x6FCD1D, TechnoClass_CanFire_OpenTopCloakFix, 0x5) you did nothing here, why you hook on this address

This has been addressed and implemented now.

[Metadorius]

LGTM but add Morton to credits too, can be merged after this

[Metadorius]

ditto, duplicate for Morton

[CnCRAZER]

@DeathFishAtEase should I put him in parenthesis on this line including he helped or should I add it under his section :P

[DeathFishAtEase]

@DeathFishAtEase should I put him in parenthesis on this line including he helped or should I add it under his section :P

In the Changelog, if there are two individuals, parentheses are used at the end with & separating them; for three or more individuals, they are separated by ,. Just like the suggestion below.
In the CREDITS, the two entries are each placed under the respective person's section. Specifically, you need to insert the - Revert Ares patch to allow OpenTopped transport customization field between lines 311 and 312.