Mutliplayer Gamespeed timer fix#2121
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Metadorius
left a comment
There was a problem hiding this comment.
LGTM, fix changelog and should be fine
|
how should we test this one? |
Find a few super weapons that show countdowns, then turn on |
Create a multiplayer game and load into a map with trigger to set large timer. At 60 fps the time no longer fluctuates |
Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
It has to be mutliplayer. Previously the timer only used gamespeed index values. Multiplayer gamespeed 0 is 60 but skirmish gamespeed 0 is unlimited. This pr has a switch between the modes to make them not jump around on multiplayer |
That's true, I omitted this part earlier because the PR title already included "Multiplayer", but it's indeed better to explicitly point this out. By the way, I noticed that you correctly handled the different FPS caps for gamespeed 1 in skirmish versus multiplayer mode - good job! |
Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
@DeathFishAtEase I'm adding documentation as @Metadorius is forcing me too :P
As I'm still learning the documentation and credit usages in this repo, once again please inform me if I've made any mistakes or forgotten something