Skip to content

Mutliplayer Gamespeed timer fix#2121

Merged
Coronia merged 7 commits intoPhobos-developers:developfrom
CnCRAZER:MP-Gamemode-timer-fix
Mar 3, 2026
Merged

Mutliplayer Gamespeed timer fix#2121
Coronia merged 7 commits intoPhobos-developers:developfrom
CnCRAZER:MP-Gamemode-timer-fix

Conversation

@CnCRAZER
Copy link
Contributor

@CnCRAZER CnCRAZER commented Feb 25, 2026

@DeathFishAtEase I'm adding documentation as @Metadorius is forcing me too :P
As I'm still learning the documentation and credit usages in this repo, once again please inform me if I've made any mistakes or forgotten something

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase DeathFishAtEase added the No Documentation Needed No documentation needed whatsoever label Feb 25, 2026
@CnCRAZER CnCRAZER changed the title [No Documentation Needed] Mutliplayer Gamespeed timer fix [No Documentation Needed] Mutliplayer Gamespeed timer fix Feb 25, 2026
Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fix changelog and should be fine

@Coronia
Copy link
Contributor

Coronia commented Feb 26, 2026

how should we test this one?

@DeathFishAtEase
Copy link
Collaborator

how should we test this one?

Find a few super weapons that show countdowns, then turn on RealTimeTimers and check whether the values are continuously jumping.

@Coronia Coronia added Needs testing Needs MP testing This PR needs to be tested for desync. labels Feb 26, 2026
@CnCRAZER
Copy link
Contributor Author

how should we test this one?

Create a multiplayer game and load into a map with trigger to set large timer. At 60 fps the time no longer fluctuates

Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
@CnCRAZER
Copy link
Contributor Author

how should we test this one?

Find a few super weapons that show countdowns, then turn on RealTimeTimers and check whether the values are continuously jumping.

It has to be mutliplayer. Previously the timer only used gamespeed index values. Multiplayer gamespeed 0 is 60 but skirmish gamespeed 0 is unlimited. This pr has a switch between the modes to make them not jump around on multiplayer

@DeathFishAtEase
Copy link
Collaborator

It has to be mutliplayer. Previously the timer only used gamespeed index values. Multiplayer gamespeed 0 is 60 but skirmish gamespeed 0 is unlimited. This pr has a switch between the modes to make them not jump around on multiplayer

That's true, I omitted this part earlier because the PR title already included "Multiplayer", but it's indeed better to explicitly point this out. By the way, I noticed that you correctly handled the different FPS caps for gamespeed 1 in skirmish versus multiplayer mode - good job!

Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
@Coronia Coronia added Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. and removed Needs testing Needs MP testing This PR needs to be tested for desync. labels Mar 1, 2026
@Coronia Coronia merged commit 366ce89 into Phobos-developers:develop Mar 3, 2026
6 checks passed
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Documentation Needed No documentation needed whatsoever Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants