Skip to content

[cpp-qt-client] Remove deprecated SignalE/SignalEFull signals in API classes #23113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Mar 6, 2026
+1 −1,471
Merged

[cpp-qt-client] Remove deprecated SignalE/SignalEFull signals in API classes #23113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ddbffb
[cpp-qt-client] Remove deprecated SignalE/SignalEFull signals in API …
MartinDelille Mar 4, 2026
d6113cc
Remove deprecated signal emissions
MartinDelille Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,32 +927,6 @@ void {{classname}}::{{nickname}}Callback({{prefix}}HttpRequestWorker *worker) {
Q_EMIT _passwordFlow.authenticationNeeded();
{{/isPassword}}{{/isOAuth}}{{/authMethods}}
} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT {{nickname}}SignalE({{#returnType}}output, {{/returnType}}error_type, error_str);
Q_EMIT {{nickname}}SignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT {{nickname}}SignalError({{#returnType}}output, {{/returnType}}error_type, error_str);
Q_EMIT {{nickname}}SignalErrorFull(worker, error_type, error_str);
}
Expand Down
4 changes: 0 additions & 4 deletions modules/openapi-generator/src/main/resources/cpp-qt-client/api-header.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,8 @@ Q_SIGNALS:
{{#operations}}{{#operation}}
void {{nickname}}SignalFull({{prefix}}HttpRequestWorker *worker{{#returnType}}, {{{.}}} summary{{/returnType}});{{/operation}}{{/operations}}
{{#operations}}{{#operation}}
Q_DECL_DEPRECATED_X("Use {{nickname}}SignalError() instead")
void {{nickname}}SignalE({{#returnType}}{{{.}}} summary, {{/returnType}}QNetworkReply::NetworkError error_type, QString error_str);
void {{nickname}}SignalError({{#returnType}}{{{.}}} summary, {{/returnType}}QNetworkReply::NetworkError error_type, const QString &error_str);{{/operation}}{{/operations}}
{{#operations}}{{#operation}}
Q_DECL_DEPRECATED_X("Use {{nickname}}SignalErrorFull() instead")
void {{nickname}}SignalEFull({{prefix}}HttpRequestWorker *worker, QNetworkReply::NetworkError error_type, QString error_str);
void {{nickname}}SignalErrorFull({{prefix}}HttpRequestWorker *worker, QNetworkReply::NetworkError error_type, const QString &error_str);{{/operation}}{{/operations}}

void abortRequestsSignal();
Expand Down
2 changes: 1 addition & 1 deletion ...es/openapi-generator/src/main/resources/cpp-qt-qhttpengine-server/apirequest.cpp.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,4 @@ void {{classname}}Request::sendCustomResponse(QIODevice *res, QNetworkReply::Net

{{#cppNamespaceDeclarations}}
}
{{/cppNamespaceDeclarations}}
{{/cppNamespaceDeclarations}}
26 changes: 0 additions & 26 deletions samples/client/petstore/cpp-qt-addDownloadProgress/client/PFXFakeApi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,32 +295,6 @@ void PFXFakeApi::getEnumInlineOrRefCallback(PFXHttpRequestWorker *worker) {
Q_EMIT getEnumInlineOrRefSignal();
Q_EMIT getEnumInlineOrRefSignalFull(worker);
} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT getEnumInlineOrRefSignalE(error_type, error_str);
Q_EMIT getEnumInlineOrRefSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT getEnumInlineOrRefSignalError(error_type, error_str);
Q_EMIT getEnumInlineOrRefSignalErrorFull(worker, error_type, error_str);
}
Expand Down
4 changes: 0 additions & 4 deletions samples/client/petstore/cpp-qt-addDownloadProgress/client/PFXFakeApi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,8 @@ class PFXFakeApi : public QObject {

void getEnumInlineOrRefSignalFull(PFXHttpRequestWorker *worker);

Q_DECL_DEPRECATED_X("Use getEnumInlineOrRefSignalError() instead")
void getEnumInlineOrRefSignalE(QNetworkReply::NetworkError error_type, QString error_str);
void getEnumInlineOrRefSignalError(QNetworkReply::NetworkError error_type, const QString &error_str);

Q_DECL_DEPRECATED_X("Use getEnumInlineOrRefSignalErrorFull() instead")
void getEnumInlineOrRefSignalEFull(PFXHttpRequestWorker *worker, QNetworkReply::NetworkError error_type, QString error_str);
void getEnumInlineOrRefSignalErrorFull(PFXHttpRequestWorker *worker, QNetworkReply::NetworkError error_type, const QString &error_str);

void abortRequestsSignal();
Expand Down
234 changes: 0 additions & 234 deletions samples/client/petstore/cpp-qt-addDownloadProgress/client/PFXPetApi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,32 +321,6 @@ void PFXPetApi::addPetCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT addPetSignalE(error_type, error_str);
Q_EMIT addPetSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT addPetSignalError(error_type, error_str);
Q_EMIT addPetSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -400,32 +374,6 @@ void PFXPetApi::allPetsCallback(PFXHttpRequestWorker *worker) {
Q_EMIT allPetsSignal(output);
Q_EMIT allPetsSignalFull(worker, output);
} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT allPetsSignalE(output, error_type, error_str);
Q_EMIT allPetsSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT allPetsSignalError(output, error_type, error_str);
Q_EMIT allPetsSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -529,32 +477,6 @@ void PFXPetApi::deletePetCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT deletePetSignalE(error_type, error_str);
Q_EMIT deletePetSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT deletePetSignalError(error_type, error_str);
Q_EMIT deletePetSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -734,32 +656,6 @@ void PFXPetApi::findPetsByStatusCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT findPetsByStatusSignalE(output, error_type, error_str);
Q_EMIT findPetsByStatusSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT findPetsByStatusSignalError(output, error_type, error_str);
Q_EMIT findPetsByStatusSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -939,32 +835,6 @@ void PFXPetApi::findPetsByTagsCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT findPetsByTagsSignalE(output, error_type, error_str);
Q_EMIT findPetsByTagsSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT findPetsByTagsSignalError(output, error_type, error_str);
Q_EMIT findPetsByTagsSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -1027,32 +897,6 @@ void PFXPetApi::getPetByIdCallback(PFXHttpRequestWorker *worker) {
Q_EMIT getPetByIdSignal(output);
Q_EMIT getPetByIdSignalFull(worker, output);
} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT getPetByIdSignalE(output, error_type, error_str);
Q_EMIT getPetByIdSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT getPetByIdSignalError(output, error_type, error_str);
Q_EMIT getPetByIdSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -1141,32 +985,6 @@ void PFXPetApi::updatePetCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT updatePetSignalE(error_type, error_str);
Q_EMIT updatePetSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT updatePetSignalError(error_type, error_str);
Q_EMIT updatePetSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -1272,32 +1090,6 @@ void PFXPetApi::updatePetWithFormCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT updatePetWithFormSignalE(error_type, error_str);
Q_EMIT updatePetWithFormSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT updatePetWithFormSignalError(error_type, error_str);
Q_EMIT updatePetWithFormSignalErrorFull(worker, error_type, error_str);
}
Expand Down Expand Up @@ -1404,32 +1196,6 @@ void PFXPetApi::uploadFileCallback(PFXHttpRequestWorker *worker) {


} else {

#if defined(_MSC_VER)
// For MSVC
#pragma warning(push)
#pragma warning(disable : 4996)
#elif defined(__clang__)
// For Clang
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
// For GCC
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

Q_EMIT uploadFileSignalE(output, error_type, error_str);
Q_EMIT uploadFileSignalEFull(worker, error_type, error_str);

#if defined(_MSC_VER)
#pragma warning(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

Q_EMIT uploadFileSignalError(output, error_type, error_str);
Q_EMIT uploadFileSignalErrorFull(worker, error_type, error_str);
}
Expand Down
Loading
Loading