Skip to content

[cpp-qt-client] Remove deprecated SignalE/SignalEFull signals in API classes#23113

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
MartinDelille:cpp-qt-remove-deprecated
Mar 6, 2026
Merged

[cpp-qt-client] Remove deprecated SignalE/SignalEFull signals in API classes#23113
wing328 merged 2 commits intoOpenAPITools:masterfrom
MartinDelille:cpp-qt-remove-deprecated

Conversation

@MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Mar 4, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) @aminya (2025/05)


Summary by cubic

Removed deprecated SignalE and SignalEFull error signal declarations and emissions from the cpp-qt client. The generator and samples now use SignalError and SignalErrorFull only, simplifying the API.

  • Refactors

    • Updated api-header.mustache and api-body.mustache to remove deprecated signals and their emissions.
    • Regenerated petstore cpp-qt and cpp-qt-addDownloadProgress sources/headers.
  • Migration

    • Replace XxxSignalE(...) with XxxSignalError(...).
    • Replace XxxSignalEFull(...) with XxxSignalErrorFull(...).
    • Update slots/lambdas to accept const QString & error_str instead of QString.

Written for commit d6113cc. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@wing328 wing328 merged commit 054af0e into OpenAPITools:master Mar 6, 2026
22 checks passed
@MartinDelille MartinDelille deleted the cpp-qt-remove-deprecated branch March 6, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants