Skip to content

Chore: [AEA-0000] - add workflow to update dev container #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 2 commits into from
Mar 23, 2026
Merged

Chore: [AEA-0000] - add workflow to update dev container #1026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1346b88
add workflow to update dev container
anthony-nhs Mar 23, 2026
ed0648d
update permissions
anthony-nhs Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/update_dev_container_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Update Devcontainer Version

on:
workflow_dispatch:
schedule:
- cron: "0 18 * * 1"

jobs:
Comment on lines +3 to +8
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scheduled workflow relies on the repository default GITHUB_TOKEN permissions (no explicit permissions: block). For least-privilege and to avoid changes in repo/org defaults impacting behavior, explicitly set the minimal permissions required by the called reusable workflow (e.g., only what’s needed to open/update PRs and/or contents).

Copilot uses AI. Check for mistakes.
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pins eps-common-workflows to a different commit SHA than the rest of the repo (most other workflows use @5ac2707...). Mixing versions can lead to inconsistent behavior and makes it harder to roll forward/back common workflow changes. Consider aligning this reference to the same SHA used elsewhere, or intentionally bump all eps-common-workflows references together to the new SHA (and document why this one differs if it must).

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@5ac2707

Copilot uses AI. Check for mistakes.
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
AUTOMERGE_APP_ID: ${{ secrets.AUTOMERGE_APP_ID }}
AUTOMERGE_PEM: ${{ secrets.AUTOMERGE_PEM }}
Loading