Chore: [AEA-0000] - add workflow to update dev container#1026
Chore: [AEA-0000] - add workflow to update dev container#1026anthony-nhs merged 2 commits intomainfrom
Conversation
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to periodically (and manually) update the repository’s dev container version by delegating to a reusable workflow in NHSDigital/eps-common-workflows.
Changes:
- Introduce a new workflow triggered by
workflow_dispatchand a weekly cron schedule. - Call the shared
update-dev-container-version.ymlreusable workflow, passingbase_branchand automerge app secrets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: "0 18 * * 1" | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
This scheduled workflow relies on the repository default GITHUB_TOKEN permissions (no explicit permissions: block). For least-privilege and to avoid changes in repo/org defaults impacting behavior, explicitly set the minimal permissions required by the called reusable workflow (e.g., only what’s needed to open/update PRs and/or contents).
|
|
||
| jobs: | ||
| update_devcontainer_version: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333 |
There was a problem hiding this comment.
This workflow pins eps-common-workflows to a different commit SHA than the rest of the repo (most other workflows use @5ac2707...). Mixing versions can lead to inconsistent behavior and makes it harder to roll forward/back common workflow changes. Consider aligning this reference to the same SHA used elsewhere, or intentionally bump all eps-common-workflows references together to the new SHA (and document why this one differs if it must).
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333 | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@5ac2707 |
|
Summary
Details