Skip to content

Dev/claude config#20

Merged
jgeudens merged 4 commits intomasterfrom
dev/claude_config
Apr 2, 2026
Merged

Dev/claude config#20
jgeudens merged 4 commits intomasterfrom
dev/claude_config

Conversation

@jgeudens
Copy link
Copy Markdown
Member

@jgeudens jgeudens commented Apr 2, 2026

Summary by CodeRabbit

  • Documentation

    • Clarified the communication layer description and updated development workflow guidance, including an explicit sequential requirement: build → tests → quality checks before completion.
  • Chores

    • Added agent configuration entries for automated build, test execution, code review and quality checks to support the new workflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 023cc6e1-18a9-4db7-baa8-230844c41c25

📥 Commits

Reviewing files that changed from the base of the PR and between 076a46c and abc943c.

📒 Files selected for processing (1)
  • CLAUDE.md
✅ Files skipped from review due to trivial changes (1)
  • CLAUDE.md

Walkthrough

Adds four Claude agent instruction files for build, test, quality and code-review workflows, and updates CLAUDE.md to document the agents and require build → tests → quality checks to pass after source changes.

Changes

Cohort / File(s) Summary
Agent Configurations
​.claude/agents/build.md, ​.claude/agents/test-runner.md, ​.claude/agents/quality.md, ​.claude/agents/code-reviewer.md
Adds agent instruction/configuration files: build (CMake + Ninja build commands, error/warning reporting), test-runner (ctest invocation, failing-test reporting), quality (clang-format/clang-tidy/clazy or pre-commit checks, report violations), and code-reviewer (Qt/C++ review prompt with structured response sections).
Documentation
CLAUDE.md
Updates development docs to reference the four new agents, broaden description of src/communication/ to “Communication (using external adapters)”, and require the execution order: build → tests → quality checks before completing changes.

Possibly related PRs

  • Dev/tooling #12: Related changes to repository developer tooling and agent/workflow scripts (clang-format/clang-tidy/clazy and agent setups).
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Dev/claude config' is vague and generic, using non-descriptive terminology that does not clearly convey what configuration changes are being made to the project. Consider using a more descriptive title such as 'Add Claude agent configuration files for build, testing, code review, and quality checks' to better communicate the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/claude_config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.claude/agents/build.md (1)

10-14: Standardise the build directory name across agent docs and scripts.

Line 11 and Line 14 use build/, while existing platform build scripts use release/. This split is likely to cause accidental mixed build/test paths.

Suggested alignment (example: switch this agent to release/)
-If the build directory doesn't exist yet, run:
-  mkdir -p build && cmake -GNinja -S . -B build
+If the build directory doesn't exist yet, run:
+  mkdir -p release && cmake -GNinja -S . -B release

 Then always run:
-  ninja -C build
+  ninja -C release
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/agents/build.md around lines 10 - 14, The doc uses build/ while
platform scripts use release/, causing inconsistent build paths; update this
agent doc to use release/ consistently by replacing occurrences of "build" and
"build/" in the snippet (the mkdir/cmake/ninja commands) with "release" and
"release/" so the commands read mkdir -p release && cmake -GNinja -S . -B
release and ninja -C release, and verify other agent docs/scripts reference the
same "release" directory to keep names aligned.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CLAUDE.md`:
- Around line 85-90: Update the inaccurate count in the Development section:
replace the header text that reads "Three sub-agents" with "Four sub-agents"
(the paragraph that precedes the list containing **`@agent-build`**,
**`@agent-test-runner`**, **`@agent-quality`**, and **`@agent-code-reviewer`**)
so the stated number matches the four listed agents.

---

Nitpick comments:
In @.claude/agents/build.md:
- Around line 10-14: The doc uses build/ while platform scripts use release/,
causing inconsistent build paths; update this agent doc to use release/
consistently by replacing occurrences of "build" and "build/" in the snippet
(the mkdir/cmake/ninja commands) with "release" and "release/" so the commands
read mkdir -p release && cmake -GNinja -S . -B release and ninja -C release, and
verify other agent docs/scripts reference the same "release" directory to keep
names aligned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3fb8116e-e03d-4988-a7a8-afb55fbf1969

📥 Commits

Reviewing files that changed from the base of the PR and between 5265f61 and 076a46c.

📒 Files selected for processing (5)
  • .claude/agents/build.md
  • .claude/agents/code-reviewer.md
  • .claude/agents/quality.md
  • .claude/agents/test-runner.md
  • CLAUDE.md

@jgeudens jgeudens merged commit e6bfc36 into master Apr 2, 2026
10 checks passed
@jgeudens jgeudens deleted the dev/claude_config branch April 2, 2026 20:25
@coderabbitai coderabbitai bot mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant