Skip to content

Update claude conf#23

Merged
jgeudens merged 2 commits intomasterfrom
dev/claude
Apr 3, 2026
Merged

Update claude conf#23
jgeudens merged 2 commits intomasterfrom
dev/claude

Conversation

@jgeudens
Copy link
Copy Markdown
Member

@jgeudens jgeudens commented Apr 3, 2026

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated internal contributor workflow guidelines to prescribe preferred build, test, and quality verification processes.
  • Chores

    • Streamlined internal build configuration and agent setup with metadata updates.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

Warning

Rate limit exceeded

@jgeudens has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 469f2aba-fc83-4390-b0ae-369156d9ffff

📥 Commits

Reviewing files that changed from the base of the PR and between 406a870 and 0ab115c.

📒 Files selected for processing (1)
  • CLAUDE.md

Walkthrough

This pull request updates agent configuration metadata and contributor workflow documentation. Changes include adding effort: low metadata to three agent configuration files, simplifying build instructions, and revising the contributor workflow in CLAUDE.md to prefer sub-agents for build, test, and quality tasks.

Changes

Cohort / File(s) Summary
Agent Configuration Files
.claude/agents/build.md, .claude/agents/quality.md, .claude/agents/test-runner.md
Added effort: low frontmatter metadata to all three agent configurations. Build.md also simplified the build instruction flow from a conditional branch to a direct "Run:" block that always creates the build directory and reconfigures CMake.
Contributor Workflow
CLAUDE.md
Updated contributor workflow documentation to recommend using sub-agents (@agent-build, @agent-test-runner, @agent-quality) for respective tasks. Replaced the pre-commit instruction with an ordered sequence: build → tests → quality checks → code review. Added requirement to update JSON-RPC schema when modifying JSON-RPC-related code.

Possibly related PRs

  • Dev/claude config #20: Adds the foundational agent files and workflow structure that this PR subsequently configures and optimises.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update claude conf' is vague and generic, using non-descriptive abbreviations that don't clearly convey what configuration changes were made or their significance. Provide a more specific title that describes the key changes, such as 'Add effort field to agent configs and update contributor workflow' or 'Update Claude agents config with effort levels and workflow requirements'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/claude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CLAUDE.md`:
- Line 39: Remove the duplicated workflow sentence "Always use these agents
rather than running the commands directly. After making source file changes:
build, then run tests, then run quality checks, then run code review - all
required steps must pass before the work is done." (the earlier occurrence) so
the Development section remains the single source of truth; if you want "code
review" included in the workflow instead, add that phrase to the existing
Development workflow sentence rather than keeping both copies.
- Line 82: The rule text "Update json-rpc schema spec when updating json-rpc
related code" is ambiguous; update the rule to specify the schema's repository
location and file path, the expected format (e.g., JSON Schema vX), and the
update procedure (run generator/validation tool and open a PR updating
path/to/schema.json), and replace the placeholder "path/to/schema.json" with the
actual path and a short command or tool name (e.g.,
"tools/json-schema-generator" or "scripts/validate-schema.sh"); reference the
rule string "Update json-rpc schema spec when updating json-rpc related code" so
contributors can find and edit the rule text accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6ce9b39d-ae9b-4ae0-af40-5e214b45fcf7

📥 Commits

Reviewing files that changed from the base of the PR and between 180a3bd and 406a870.

📒 Files selected for processing (4)
  • .claude/agents/build.md
  • .claude/agents/quality.md
  • .claude/agents/test-runner.md
  • CLAUDE.md

CLAUDE.md Outdated
- Prefer readability and maintainability over using the latest C++ features (avoid syntax sugar that may be less familiar to new contributors).
- Avoid lambda expressions with more than 2 captures or multiple statements; use named functions instead for clarity.
- Make sure to document public functions with brief Doxygen comments in the source file
- Update json-rpc schema spec when updating json-rpc related code
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clarify json-rpc schema spec update requirement.

The new rule requires updating the "json-rpc schema spec" when modifying related code, but lacks essential context: where is the schema spec located, what format is it in, and how should contributors update it?

📝 Suggested improvement
-- Update json-rpc schema spec when updating json-rpc related code
+- Update json-rpc schema spec (located at `path/to/schema.json`) when updating json-rpc related code

Replace path/to/schema.json with the actual path.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` at line 82, The rule text "Update json-rpc schema spec when
updating json-rpc related code" is ambiguous; update the rule to specify the
schema's repository location and file path, the expected format (e.g., JSON
Schema vX), and the update procedure (run generator/validation tool and open a
PR updating path/to/schema.json), and replace the placeholder
"path/to/schema.json" with the actual path and a short command or tool name
(e.g., "tools/json-schema-generator" or "scripts/validate-schema.sh"); reference
the rule string "Update json-rpc schema spec when updating json-rpc related
code" so contributors can find and edit the rule text accordingly.

@jgeudens jgeudens merged commit fdf55f1 into master Apr 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant