Add Across Predict withdraw quote support#8760
Open
pedronfigueiredo wants to merge 1 commit into
Open
Conversation
a202a20 to
f4feefb
Compare
This was referenced May 11, 2026
a4ae73b to
6077863
Compare
f4feefb to
86b0f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 2 of 4 in the core stack for Predict withdraws over Across.
Stack
Validation
yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/across-quotes.test.ts src/strategy/across/AcrossStrategy.test.tsyarn changelog:validateyarn workspace @metamask/transaction-pay-controller run testyarn workspace @metamask/transaction-controller run testNote
Medium Risk
Changes Across quote construction and gas/fee normalization for post-quote
predictWithdrawflows, including new error paths and gas-fee-token re-quoting behavior that could affect quoting correctness and strategy selection.Overview
Adds Across quote support for post-quote
predictWithdrawflows, switching these requests toexactInput, sending no destination actions, and optionally passingrefundAddressthrough to Across.Extends quote normalization to combine the original (pre-Across) transaction gas/fees into
sourceNetworkand gas limits for post-quote requests, and updates gas-station accounting accordingly.Introduces special-case handling for EIP-7702 authorization lists: allow source-chain authorization lists only for post-quote
predictWithdrawquotes with empty Across actions, while continuing to reject authorization lists elsewhere. Also expands the re-quote “reserve source token for gas-fee-token” flow to cover post-quote withdraws, with stricter failures instead of falling back to phase-1 in unsafe cases.Reviewed by Cursor Bugbot for commit 86b0f66. Bugbot is set up for automated code reviews on this repo. Configure here.