Skip to content

Add Across Predict withdraw plumbing#8759

Open
pedronfigueiredo wants to merge 1 commit into
mainfrom
pnf/predict-withdraw-across-plumbing
Open

Add Across Predict withdraw plumbing#8759
pedronfigueiredo wants to merge 1 commit into
mainfrom
pnf/predict-withdraw-across-plumbing

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented May 11, 2026

Summary

This is PR 1 of 4 in the core stack for Predict withdraws over Across.

  • Adds TransactionType.predictAcrossWithdraw.
  • Treats isPostQuote requests as actionable for Across support checks.
  • Allows source-chain authorization lists only for post-quote Predict withdraw detection, where the original withdraw is not encoded as an Across destination action.
  • Generalizes transaction-pay refund documentation from Relay-only language to quote-provider language.

Stack

  1. This PR: plumbing to identify Predict Across withdraws
  2. Add Across Predict withdraw quote support #8760: quote support
  3. Add Across Predict withdraw submit support #8761: submit support
  4. Fix Across Predict withdraw gas payment edges #8762: gas payment edge cases

Validation

  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/AcrossStrategy.test.ts
  • Full stack validation was run on the final stacked branch:
    • yarn changelog:validate
    • yarn workspace @metamask/transaction-pay-controller run test
    • yarn workspace @metamask/transaction-controller run test

Note

Medium Risk
Modifies Across pay-strategy eligibility logic (including EIP-7702 authorizationList handling) which can affect whether quotes are returned/submitted for certain transactions.

Overview
Adds a new TransactionType.predictAcrossWithdraw and records it in the @metamask/transaction-controller changelog.

Updates the Across pay strategy to treat isPostQuote quote requests as actionable and to only accept them when the underlying transaction is a Predict withdraw, including allowing source-chain authorizationList only for this specific post-quote Predict withdraw path. This includes a new helper (hasUnsupportedTransactionAuthorizationList), expanded AcrossStrategy tests, and a tweak so isPostQuote requests are recognized by isAcrossQuoteRequest.

Clarifies refundTo docs in transaction-pay types to be quote-provider (not Relay) specific, and updates the @metamask/transaction-pay-controller changelog.

Reviewed by Cursor Bugbot for commit 6077863. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/predict-withdraw-across-plumbing branch from a4ae73b to 6077863 Compare May 11, 2026 13:51
@pedronfigueiredo pedronfigueiredo requested a review from jpuri May 11, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant