Add Across Predict withdraw plumbing#8759
Open
pedronfigueiredo wants to merge 1 commit into
Open
Conversation
ad1509e to
a4ae73b
Compare
This was referenced May 11, 2026
a4ae73b to
6077863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1 of 4 in the core stack for Predict withdraws over Across.
TransactionType.predictAcrossWithdraw.isPostQuoterequests as actionable for Across support checks.Stack
Validation
yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/AcrossStrategy.test.tsyarn changelog:validateyarn workspace @metamask/transaction-pay-controller run testyarn workspace @metamask/transaction-controller run testNote
Medium Risk
Modifies Across pay-strategy eligibility logic (including EIP-7702
authorizationListhandling) which can affect whether quotes are returned/submitted for certain transactions.Overview
Adds a new
TransactionType.predictAcrossWithdrawand records it in the@metamask/transaction-controllerchangelog.Updates the Across pay strategy to treat
isPostQuotequote requests as actionable and to only accept them when the underlying transaction is a Predict withdraw, including allowing source-chainauthorizationListonly for this specific post-quote Predict withdraw path. This includes a new helper (hasUnsupportedTransactionAuthorizationList), expanded AcrossStrategy tests, and a tweak soisPostQuoterequests are recognized byisAcrossQuoteRequest.Clarifies
refundTodocs in transaction-pay types to be quote-provider (not Relay) specific, and updates the@metamask/transaction-pay-controllerchangelog.Reviewed by Cursor Bugbot for commit 6077863. Bugbot is set up for automated code reviews on this repo. Configure here.