Skip to content

Use npm ci instead of npm install in build.rs #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristianPavilonis merged 3 commits into from
Feb 28, 2026
Merged

Use npm ci instead of npm install in build.rs #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34a1b4b
Use npm ci instead of npm install in build.rs
ChristianPavilonis Feb 26, 2026
216f603
Update docs to reference npm ci instead of npm install
ChristianPavilonis Feb 27, 2026
8302020
Merge branch 'main' into fix/build-rs-npm-ci
aram356 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/js/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ fn main() {
if let Some(npm_path) = npm.as_deref() {
if !ts_dir.join("node_modules").exists() {
let status = Command::new(npm_path)
.arg("install")
.arg("ci")
.current_dir(&ts_dir)
.status();
if !status
.as_ref()
.map(std::process::ExitStatus::success)
.unwrap_or(false)
{
warn!("tsjs: npm install failed; using existing dist if available");
warn!("tsjs: npm ci failed; using existing dist if available");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ VitePress documentation site for Trusted Server.

```bash
# Install dependencies
npm install
npm ci

# Start dev server (available at localhost:5173)
npm run dev
Expand Down
2 changes: 1 addition & 1 deletion docs/guide/error-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ ERROR: npm run build:custom failed

```bash
cd crates/js/lib
npm install
npm ci
```

2. Test build manually:
Expand Down