Use npm ci instead of npm install in build.rs#385
Merged
ChristianPavilonis merged 3 commits intomainfrom Feb 28, 2026
Merged
Conversation
Prevents package-lock.json from being modified when node_modules is missing, keeping diffs clean on fresh worktrees. Closes #378
aram356
requested changes
Feb 26, 2026
Collaborator
aram356
left a comment
There was a problem hiding this comment.
Thanks for finding this:
can you please update docs:
./guide/error-reference.md:npm install
./README.md:npm install
aram356
approved these changes
Feb 27, 2026
Collaborator
aram356
left a comment
There was a problem hiding this comment.
👍 Looks good. Please merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.rsfromnpm installtonpm ciso that building on a fresh worktree does not modifypackage-lock.jsonand pollute diffs.Changes
crates/js/build.rs.arg("install")to.arg("ci")and updated warning messageCloses
Closes #378
Test plan
cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkcd crates/js/lib && npx vitest runcd crates/js/lib && npm run formatcd docs && npm run formatcargo build --bin trusted-server-fastly --release --target wasm32-wasip1Checklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!)