Skip to content

fix undo for checkboxes #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayush2k02 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix undo for checkboxes #3946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion frontend/src/utility-functions/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,15 @@ function detectShake(e: PointerEvent | MouseEvent): boolean {
}

function targetIsTextField(target: EventTarget | HTMLElement | undefined): boolean {
return target instanceof HTMLElement && (target.nodeName === "INPUT" || target.nodeName === "TEXTAREA" || target.isContentEditable);
if (!(target instanceof HTMLElement)) return false;
if (target.nodeName === "TEXTAREA" || target.isContentEditable) return true;
if (target instanceof HTMLInputElement) {
const inputType = target.type.toLowerCase();
// Only consider actual text-entry input types as text fields, not checkboxes, radio buttons, etc.
const textInputTypes = ["text", "password", "email", "number", "search", "tel", "url", "date", "datetime-local", "month", "time", "week"];
return textInputTypes.includes(inputType);
}
return false;
}

function potentiallyRestoreCanvasFocus(e: Event) {
Expand Down
Loading