fix undo for checkboxes

[Ayush2k02]

Replaces #3866 (branch was force-pushed after file location changed in master)

---

Bug: Keyboard shortcuts like Cmd+Z were blocked when a checkbox had focus because targetIsTextField() treated all elements as text fields.

Fix: Only treat text-like input types (text, password, email, etc.) as text fields, not checkboxes or radio buttons.

Screen.Recording.2026-03-07.at.5.32.57.PM.mov

Fixes: https://discord.com/channels/731730685944922173/731738914812854303/1479627959127117924

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical usability issue by refining the logic that determines if an HTML element is a text field. By making this distinction more precise, it restores expected behavior for keyboard shortcuts like undo/redo, which were previously inhibited by non-text input elements, significantly improving the user experience for form interactions.

Highlights

• Refined targetIsTextField Function: The targetIsTextField utility function has been updated to accurately identify text-entry input fields. Previously, it incorrectly classified all elements, including checkboxes, as text fields.
• Fixed Undo/Redo Shortcut Blocking: This change resolves a bug where keyboard shortcuts like Cmd+Z (undo) were blocked when a non-text input element, such as a checkbox, had focus, by ensuring only actual text-like inputs are considered text fields.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where keyboard shortcuts were incorrectly blocked for non-text input fields like checkboxes. The change correctly refines targetIsTextField to only identify text-entry-related input types. The implementation is clear and effectively resolves the bug. I've added one suggestion to slightly optimize the new logic for better performance.

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[Ayush2k02]

Screen.Recording.2026-03-24.at.9.23.40.AM.mov

Working fine after the recent rebase against main and opening up this new PR

[Ayush2k02]

@Keavon , here is the new PR, wasn't able to push to the previous one