Add #EuroPython #Python hashtags to bingo share#1699
Open
hugovk wants to merge 3 commits into
Open
Conversation
Member
Preview available
|
| } | ||
|
|
||
| const BINGO_PAGE_URL = 'https://ep2026.europython.eu/#bingo'; | ||
| const BINGO_PAGE_URL = 'https://ep2026.europython.eu/bingo'; |
Contributor
There was a problem hiding this comment.
This was suggested to me before, but other sections have URLS like https://ep2026.europython.eu/#krakow - don't we want to be consistent? And does the hash even matter?
| const base = `I've attended ${count} EuroPython conference${count !== 1 ? 's' : ''}! 🐍`; | ||
| const body = count > 0 ? `${base}\n\n${attended.join(' · ')}` : base; | ||
| return `${body}\n\nWhat about you: ${BINGO_PAGE_URL}`; | ||
| return `${body}\n\nWhat about you? ${BINGO_PAGE_URL}\n#EuroPython #Python`; |
Contributor
There was a problem hiding this comment.
Suggested change
| return `${body}\n\nWhat about you? ${BINGO_PAGE_URL}\n#EuroPython #Python`; | |
| return `${body}\n\nWhat about you? ${BINGO_PAGE_URL}\n\n#EuroPython #Python`; |
Contributor
There was a problem hiding this comment.
This would help readability
Contributor
|
@hugovk I don't really know why, but this change breaks LinkedIn sharing by removing the URL, by clipping everything after the last question including the URL: this PR prod |
dariagrudzien
requested changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also list social networks in same order as homepage: