Skip to content

Lookup: Fix deprecation warning for function width/height in dropDownOptions (T1330990) #34111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-farkhutdinov wants to merge 2 commits into
base: 26_1
Choose a base branch
from
+18 −1
Open

Lookup: Fix deprecation warning for function width/height in dropDownOptions (T1330990) #34111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba34ce4
Lookup: Fix deprecation warning for function width/height in dropDown…
Jun 24, 2026
3743e6f
Merge branch '26_1' into 26_1_T1330990
r-farkhutdinov Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/ui/lookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ class Lookup extends DropDownList<LookupProperties> {
showDropDownButton: false,
focusStateEnabled: false,
dropDownOptions: {
_ignoreFunctionValueDeprecation: true,
showTitle: true,
// @ts-expect-error The width cannot be a static value due to the mechanism of size updates
width: () => getSize('width'),
Expand Down Expand Up @@ -233,7 +234,6 @@ class Lookup extends DropDownList<LookupProperties> {
dropDownCentered: true,
_scrollToSelectedItemEnabled: true,
dropDownOptions: {
_ignoreFunctionValueDeprecation: true,
shading: false,
showTitle: false,
// The height cannot be a static value due to the mechanism of size updates
Expand Down
17 changes: 17 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2555,6 +2555,23 @@ QUnit.module('popup options', {
}
});
});

QUnit.test('should not log W0017 deprecation warning on popup open for function-valued width/height (T1330990)', function(assert) {
const logStub = sinon.stub(errors, 'log');

try {
$('#lookup').dxLookup({
items: [1, 2, 3],
opened: true,
});

const warningCalls = logStub.args.filter(args => args[0] === 'W0017');

assert.strictEqual(warningCalls.length, 0, 'no W0017 warnings should be logged when opening the popup');
} finally {
logStub.restore();
}
});
});

QUnit.module('list options', {
Expand Down
Loading