Lookup: Fix deprecation warning for function width/height in dropDownOptions (T1330990)#34111
Open
r-farkhutdinov wants to merge 2 commits into
Open
Lookup: Fix deprecation warning for function width/height in dropDownOptions (T1330990)#34111r-farkhutdinov wants to merge 2 commits into
r-farkhutdinov wants to merge 2 commits into
Conversation
…Options (T1330990)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a deprecation warning emitted when dxLookup opens its drop-down overlay with function-valued width/height in dropDownOptions, by passing the internal _ignoreFunctionValueDeprecation flag to the underlying Popup/Popover options.
Changes:
- Add
_ignoreFunctionValueDeprecation: truetodxLookupdefaultdropDownOptionsso Popup/Popover won’t logW0017for function-valued sizing options. - Remove the now-redundant
_ignoreFunctionValueDeprecationfrom a theme-specificdropDownOptionsrule. - Add a QUnit test asserting that opening a Lookup does not log
W0017.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js | Adds a regression test intended to ensure W0017 is not logged when opening the Lookup overlay. |
| packages/devextreme/js/__internal/ui/lookup.ts | Ensures Lookup’s default overlay options include _ignoreFunctionValueDeprecation and removes a redundant theme-specific placement. |
marker-dao
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.