-
Notifications
You must be signed in to change notification settings - Fork 624
Pre 0.10.0-rc1 #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pre 0.10.0-rc1 #2905
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/bin/sh | ||
| LIB_VER=$(grep '<revision>' pom.xml | sed -e 's|[[:space:]]*<[/]*revision>[[:space:]]*||g') | ||
| find `pwd`/examples -type f -name pom.xml -exec sed -i -e "s|\(<clickhouse-java.version>\).*\(<\)|\1$LIB_VER\2|g" {} \; | ||
| for d in $(ls -d `pwd`/examples/*/); do \ | ||
| if [ -e $d/pom.xml ]; then cd $d && mvn --batch-mode --no-transfer-progress clean compile; fi; | ||
| if [ -e $d/gradlew ]; then cd $d && ./gradlew clean build; fi; | ||
| done | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Script ignores build failuresMedium Severity The new Reviewed by Cursor Bugbot for commit 73156f8. Configure here. |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
|
|
||
| ch_java_client_version=0.9.8 | ||
| ch_java_client_version=0.10.0-rc1 |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GNU sed breaks on macOS
Medium Severity
The new script uses
sed -i -eas in Linux CI, but BSDsedon macOS treats the argument after-ias a backup extension, so in-place edits of examplepom.xmlfiles fail or behave incorrectly on developer Macs.Reviewed by Cursor Bugbot for commit 73156f8. Configure here.