Pre 0.10.0-rc1#2905
Open
chernser wants to merge 2 commits into
Open
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
TriageCategory: Summary What this impacts
Required reviewer action
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 73156f8. Configure here.
| @@ -0,0 +1,8 @@ | |||
| #!/bin/sh | |||
| LIB_VER=$(grep '<revision>' pom.xml | sed -e 's|[[:space:]]*<[/]*revision>[[:space:]]*||g') | |||
| find `pwd`/examples -type f -name pom.xml -exec sed -i -e "s|\(<clickhouse-java.version>\).*\(<\)|\1$LIB_VER\2|g" {} \; | |||
There was a problem hiding this comment.
GNU sed breaks on macOS
Medium Severity
The new script uses sed -i -e as in Linux CI, but BSD sed on macOS treats the argument after -i as a backup extension, so in-place edits of example pom.xml files fail or behave incorrectly on developer Macs.
Reviewed by Cursor Bugbot for commit 73156f8. Configure here.
| for d in $(ls -d `pwd`/examples/*/); do \ | ||
| if [ -e $d/pom.xml ]; then cd $d && mvn --batch-mode --no-transfer-progress clean compile; fi; | ||
| if [ -e $d/gradlew ]; then cd $d && ./gradlew clean build; fi; | ||
| done |
There was a problem hiding this comment.
Script ignores build failures
Medium Severity
The new build_examples.sh loops over examples and runs mvn clean compile or ./gradlew clean build without set -e or checking exit codes. If an early example fails, the loop keeps going and the script can still exit successfully depending on the last command, masking broken examples during local release checks.
Reviewed by Cursor Bugbot for commit 73156f8. Configure here.
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: