-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Feature/storage/bifrost create session #48940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
browndav-msft
wants to merge
80
commits into
Azure:feature/storage/bifrost
Choose a base branch
from
browndav-msft:feature/storage/bifrost-createSession
base: feature/storage/bifrost
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
a8e418c
generate base files based on swagger docs
browndav-msft 92ea65a
create live tests for createSession
browndav-msft d90ea8e
add recordings
browndav-msft 5c81715
create new files based on swagger update
browndav-msft dab6ac3
add two params to BlobContainerClient#createSessionWithResponse
browndav-msft 06bbceb
add sanitizers for SessionToken and SessionKey to BlobTestBase
browndav-msft dd12bfd
add recording for createSessionReturnsTokenAndKey
browndav-msft a201609
create StorageSessionCredential with isExpired
browndav-msft ed36a92
create BlobSessionClient so that BlobSessionProvider takes it as a de…
browndav-msft 183216a
create BlobSEssionClient with tests
browndav-msft 14d51e5
add recorings for BlobSessionClient
browndav-msft cee223e
fix BlobContainerAsyncClient to match new swagger, add new recording
browndav-msft 53edfce
add SessionProvider and SessionProviderTest
browndav-msft ba27517
add accountName to BlobSessionClient
browndav-msft 7b1e62f
add accountName to StorageSessionCredential and SesionTestHelper
browndav-msft a5033bd
wip
browndav-msft 651fc0f
change sessionprovider to SEssionTokenCredentialPolicy
browndav-msft 5173527
wip
browndav-msft 2ae4c4d
move session tests from containerapi to blobsessionclienttests
browndav-msft dc0609e
fix blobsessiontests and add place holder for end-to-end tests in con…
browndav-msft d2f1e0d
add recordings for blobsessionclient
browndav-msft 70b0552
linting
browndav-msft cf7f3d3
refactor cache into separate class so it follows BearerTokenAuthentic…
browndav-msft 7954161
add 503 fallback
browndav-msft 5427d79
add tests for udsas, but disabled for now
browndav-msft cce1e4e
refactor createContext to use hardcoded endpoint
browndav-msft ce166ec
add SessionMode and tests for SessionMode
browndav-msft 7a5ee36
add sessionOptions to buildPipeline, add null to builders not using s…
browndav-msft a4c9e43
move SessionTokenCredentialPolicy ahead of StorageBearerTokenChalleng…
browndav-msft 96e2dd7
fix linting issues
browndav-msft 1179b0d
add session to BlobServiceClients and BlobServiceClientBuildeer
browndav-msft e10c762
change expiration so that it defaults to 5 minutes, if there is no ex…
browndav-msft f1257f4
move SessionOptions so that it is public
browndav-msft 54e05a1
remove old SessionOptions
browndav-msft 4d81146
remove unnecessary references to containerName and serviceVersion
browndav-msft 7e8eb55
add BlobContainerSessionInfo, add other Copilot recommendations
browndav-msft ae10983
delete BlobContainerSessionInfo, restore return CreateSessionResponse
browndav-msft 384909d
create createSession end-to-end test with recordings
browndav-msft 7f6247a
only allow get requests for getblob
browndav-msft 1a9a611
wrap tests in try-with-resources
browndav-msft 7436cf1
make createSession package private
browndav-msft 7d347c9
fixes based on copilot suggestions
browndav-msft d7aef3c
Update sdk/storage/azure-storage-blob/src/main/java/com/azure/storage…
browndav-msft e9b5228
add containerName to SessionOptions
browndav-msft 2f11835
move accountName to SessionOptions
browndav-msft 92691d1
refactor: SessionTokenCredentialPolicy accepts bearer policy as const…
browndav-msft 825159d
refactor: introduce AuthStrategy enum and consolidate analyzeRequest
browndav-msft ede26db
refactor: remove redundant restype check from analyzeRequest
browndav-msft 8ee7327
change sessionmode from always to singlespecifciedcontainer, add reso…
browndav-msft 887992b
wrap bearer token in sessioncredentialpolicy
browndav-msft 1f62d31
fix NPE for SessionOptions, sessionoptions always non null
browndav-msft 0a93c24
add tests for sessiontokencredpolicy and storagesessioncred
browndav-msft c741397
add logic to avoid wrapping Bearertoken, if session is not needed
browndav-msft 0ef51e6
add overloaded oauth in blobtestbase to be able to add sessionoptions
browndav-msft b7e8243
add overloaded getOAuthServiceAsyncClient to be able to pass session …
browndav-msft e54db67
add custom buildStringToSign to remove `0` from get requests
browndav-msft e7b935c
readd versions
browndav-msft 9d599d7
readd ci.system.properties
browndav-msft 2cd768c
change session options check for null in BuilderHelper which affected…
browndav-msft 7754d50
add recordings for create sessions, change time to testResource time
browndav-msft d01f8f0
add requestInspectionPolicy and overloaded getoauth client in base test
browndav-msft 26965a5
fix null sessionsoptions issue
browndav-msft 9c5018f
add fix in storagesessioncredntial for query params
browndav-msft 4e90c72
add SessionTokenCredPolicy to checks for anonymousAccess
browndav-msft c819991
remove constructor for BlobSessionClients that uses parse url
browndav-msft a988e5b
linting issues, remove SessionOptions from service methods
browndav-msft 84061e8
add comments to policyrefreshNearExpiry test
browndav-msft edc4ebe
fix linting issues
browndav-msft a66b67f
add check for container name
browndav-msft 4335955
fix return javadoc for SessionMode
browndav-msft 72a8bb8
add LOGGER and appropriate error throwing in BlobSessionClient
browndav-msft b3a8a16
changes based on feedback from isabelle
browndav-msft c96f460
add single retry for all 401 errors
browndav-msft ca7eedb
remove unused imports
browndav-msft 019787a
add suppression for SessionTokenPolicy for linting
browndav-msft 08a8d39
fix ubuntu tests hanging by removing local dns bypass
browndav-msft 342eb15
add session for blob client with tests
browndav-msft 8429d1a
create unified http transport between data requests and session reque…
browndav-msft 4e75168
test multiple concurrency
browndav-msft 920d589
add branching if for bearer policy
browndav-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,6 +147,7 @@ public BlobContainerClient getBlobContainerClient(String containerName) { | |
| if (CoreUtils.isNullOrEmpty(containerName)) { | ||
| containerName = BlobContainerClient.ROOT_CONTAINER_NAME; | ||
| } | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: remove this |
||
| return new BlobContainerClient(getHttpPipeline(), getAccountUrl(), getServiceVersion(), getAccountName(), | ||
| containerName, customerProvidedKey, encryptionScope, blobContainerEncryptionScope); | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this supposed to be package private? same question for
createSessionWithResponseand async counterparts.