Feature/storage/bifrost create session by browndav-msft · Pull Request #48940 · Azure/azure-sdk-for-java

browndav-msft · 2026-04-26T17:31:59Z

move all commits from bifrost-base/createSession

- downgrade blobserviceversion to 2026_04_06 - change AZURE_LIVE_TEST_SERVICE_VERSION to V2026_04_06 in ci.system.properties in azure-storage-common - create both sync and async

…p instead of ContainersImpl

…tainerapitests

…ationPolicy + AccessTokenCache pattern

…essions

…eAuthorizationPolicy

…options

… other tests

ibrandes

overall, this looks really good! i left a couple comments about future refactoring before its beta release that can be addressed later on down the line. i'd also like to do a deeper dive into some of the caching and credential logic before beta release, but right now, i think it's in a good state for the private drop.

ibrandes · 2026-04-26T18:07:33Z

            : BuilderHelper.buildPipeline(storageSharedKeyCredential, tokenCredential, azureSasCredential, sasToken,
                endpoint, retryOptions, coreRetryOptions, logOptions, clientOptions, httpClient, perCallPolicies,
-                perRetryPolicies, configuration, audience, LOGGER);
+                perRetryPolicies, configuration, audience, LOGGER, null, null);


also for my own knowledge - why don't we pass in sessionOptions here?

The sessions are supposed to be container scoped. If we passed sessionOptions to a blob, we wouldn't have any way to set it, so I think we'd have to expose a setter for sessionOptions. But creating a session for a single blob would just be overhead, I think. Unless I'm thinking about this all wrong.

Its a valid scenario to create a session for a single blob. What if you are doing a very large blob download with many buffered download calls?

Okay. I'll read through this and make the change.

ibrandes · 2026-04-26T18:45:35Z

+    Mono<StorageSessionCredential> createSessionAsync() {
+        CreateSessionConfiguration config
+            = new CreateSessionConfiguration().setAuthenticationType(AuthenticationType.HMAC);
+
+        return azureBlobStorage.getContainers()
+            .createSessionWithResponseAsync(containerName, config, null, null)
+            .map(this::toCredential);
+    }
+
+    StorageSessionCredential createSessionSync() {
+        CreateSessionConfiguration config
+            = new CreateSessionConfiguration().setAuthenticationType(AuthenticationType.HMAC);
+
+        Response<CreateSessionResponse> response = azureBlobStorage.getContainers()
+            .createSessionWithResponse(containerName, config, null, null, Context.NONE);
+        return toCredential(response);
+    }


across this whole feature, there are 3 separate API calls. i think it would be worth it to create a small internal sync and async helper somewhere builds the config and maps the response that is shared by BlobSessionClient and container clients. by doing this, we can potentially avoid diverging code paths by having everything in the same place.

@ibrandes should I refactor this now or for the beta?

ibrandes · 2026-04-26T18:55:56Z

+     * parameter, while in {@link SessionMode#SINGLE_SPECIFIED_CONTAINER} mode);
+     * {@link AuthStrategy#USE_BEARER_TOKEN} otherwise.
+     */
+    AuthStrategy analyzeRequest(HttpPipelineCallContext context) {


also out of scope for this PR, but a refactoring change we should consider before the beta release:

this method was kind of hard to follow, it would be good to extract request eligibility logic from it. the current logic is deterministic and stateless (mode, method, URL shape, comp, container match), so it can live in a small pure utility (e.g., SessionEligibility)

by doing this, it should be easier to do isolated unit testing on it, and if AUTO behavior ever evolves, it will be easier to update.

Cool. I'll do this for the beta

ibrandes · 2026-04-27T17:45:44Z

/azp run java - storage - ci

azure-pipelines · 2026-04-27T17:45:52Z

No pipelines are associated with this pull request.

…st, add ResourceLock for live tests

browndav-msft added 30 commits April 26, 2026 13:28

generate base files based on swagger docs

a8e418c

create live tests for createSession

92ea65a

- downgrade blobserviceversion to 2026_04_06 - change AZURE_LIVE_TEST_SERVICE_VERSION to V2026_04_06 in ci.system.properties in azure-storage-common - create both sync and async

add recordings

d90ea8e

create new files based on swagger update

5c81715

add two params to BlobContainerClient#createSessionWithResponse

dab6ac3

add sanitizers for SessionToken and SessionKey to BlobTestBase

06bbceb

add recording for createSessionReturnsTokenAndKey

dd12bfd

create StorageSessionCredential with isExpired

a201609

create BlobSessionClient so that BlobSessionProvider takes it as a de…

ed36a92

…p instead of ContainersImpl

create BlobSEssionClient with tests

183216a

add recorings for BlobSessionClient

14d51e5

fix BlobContainerAsyncClient to match new swagger, add new recording

cee223e

add SessionProvider and SessionProviderTest

53edfce

add accountName to BlobSessionClient

ba27517

add accountName to StorageSessionCredential and SesionTestHelper

7b1e62f

wip

a5033bd

change sessionprovider to SEssionTokenCredentialPolicy

651fc0f

wip

5173527

move session tests from containerapi to blobsessionclienttests

2ae4c4d

fix blobsessiontests and add place holder for end-to-end tests in con…

dc0609e

…tainerapitests

add recordings for blobsessionclient

d2f1e0d

linting

70b0552

refactor cache into separate class so it follows BearerTokenAuthentic…

cf7f3d3

…ationPolicy + AccessTokenCache pattern

add 503 fallback

7954161

add tests for udsas, but disabled for now

5427d79

refactor createContext to use hardcoded endpoint

cce1e4e

add SessionMode and tests for SessionMode

ce166ec

add sessionOptions to buildPipeline, add null to builders not using s…

7a5ee36

…essions

move SessionTokenCredentialPolicy ahead of StorageBearerTokenChalleng…

a4c9e43

…eAuthorizationPolicy

fix linting issues

96e2dd7

browndav-msft added 16 commits April 26, 2026 13:28

add overloaded oauth in blobtestbase to be able to add sessionoptions

0ef51e6

add overloaded getOAuthServiceAsyncClient to be able to pass session …

b7e8243

…options

add custom buildStringToSign to remove 0 from get requests

e54db67

readd versions

e7b935c

readd ci.system.properties

9d599d7

change session options check for null in BuilderHelper which affected…

2cd768c

… other tests

add recordings for create sessions, change time to testResource time

7754d50

add requestInspectionPolicy and overloaded getoauth client in base test

d01f8f0

fix null sessionsoptions issue

26965a5

add fix in storagesessioncredntial for query params

9c5018f

add SessionTokenCredPolicy to checks for anonymousAccess

4e90c72

remove constructor for BlobSessionClients that uses parse url

c819991

linting issues, remove SessionOptions from service methods

a988e5b

add comments to policyrefreshNearExpiry test

84061e8

fix linting issues

edc4ebe

add check for container name

a66b67f

github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 26, 2026

browndav-msft added 2 commits April 26, 2026 13:41

fix return javadoc for SessionMode

4335955

add LOGGER and appropriate error throwing in BlobSessionClient

72a8bb8

ibrandes reviewed Apr 26, 2026

View reviewed changes

browndav-msft added 4 commits April 26, 2026 16:29

changes based on feedback from isabelle

b3a8a16

add single retry for all 401 errors

c96f460

remove unused imports

ca7eedb

add suppression for SessionTokenPolicy for linting

019787a

browndav-msft added 4 commits April 27, 2026 17:06

fix ubuntu tests hanging by removing local dns bypass

08a8d39

add session for blob client with tests

342eb15

create unified http transport between data requests and session reque…

8429d1a

…st, add ResourceLock for live tests

test multiple concurrency

4e75168

Conversation

browndav-msft commented Apr 26, 2026

Uh oh!

ibrandes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ibrandes Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

browndav-msft Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

gapra-msft Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

browndav-msft Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ibrandes Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

browndav-msft Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

ibrandes Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

browndav-msft Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibrandes commented Apr 27, 2026

Uh oh!

azure-pipelines Bot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

browndav-msft Apr 26, 2026 •

edited

Loading