Skip to content

Feat/add metrics notice to first notice#7955

Open
lingyun14beta wants to merge 6 commits intoAstrBotDevs:masterfrom
lingyun14beta:feat/add-metrics-notice-to-first-notice
Open

Feat/add metrics notice to first notice#7955
lingyun14beta wants to merge 6 commits intoAstrBotDevs:masterfrom
lingyun14beta:feat/add-metrics-notice-to-first-notice

Conversation

@lingyun14beta
Copy link
Copy Markdown
Contributor

@lingyun14beta lingyun14beta commented May 2, 2026

#7946 正在为 WebUI 添加禁用此功能的配置选项,本 PR 依赖 #7946 合并。

Modifications / 改动点

修改 FIRST_NOTICE.md:添加说明(中文)
修改 FIRST_NOTICE.en-US.md:添加说明(英文)
新增 FIRST_NOTICE.ru-RU.md:新增俄语版首次提示。

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

image

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Document anonymous usage statistics collection in first-run notices and add a Russian localized first notice.

New Features:

  • Introduce a Russian-language first notice document for AstrBot users.

Documentation:

  • Update English and Chinese first notice documents to mention anonymous usage statistics and how to disable them.
  • Add a Russian first notice document covering key usage and privacy information for AstrBot.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 2, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the English and Russian notices, confirm that the label for the toggle path (“Normal Config” / “Обычная конфигурация”) exactly matches the wording shown in the Web UI so users can easily find the setting.
  • Consider aligning the structure and wording of the new Russian notice more closely with the existing Chinese/English versions (e.g., using the same section breaks and emphasis) to keep all first-run notices consistent across locales.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the English and Russian notices, confirm that the label for the toggle path (“Normal Config” / “Обычная конфигурация”) exactly matches the wording shown in the Web UI so users can easily find the setting.
- Consider aligning the structure and wording of the new Russian notice more closely with the existing Chinese/English versions (e.g., using the same section breaks and emphasis) to keep all first-run notices consistent across locales.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a notice regarding anonymous usage statistics collection to the English and Chinese versions of the first-time notice and introduces a new Russian translation of the full notice. The feedback suggests refining the Russian translation of 'Normal Config' to 'Основные настройки' to better align with standard software terminology and ensure consistency with the WebUI.

Comment thread FIRST_NOTICE.ru-RU.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant