Feat/add metrics notice to first notice#7954
Closed
lingyun14beta wants to merge 3 commits intoAstrBotDevs:masterfrom
Closed
Feat/add metrics notice to first notice#7954lingyun14beta wants to merge 3 commits intoAstrBotDevs:masterfrom
lingyun14beta wants to merge 3 commits intoAstrBotDevs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Please double-check that the terms used for the settings section ("Normal Config", "普通配置", "Обычная конфигурация") exactly match the current UI labels so users can easily find where to disable metrics collection.
- In the Russian notice, consider aligning formatting with the other locales (e.g., splitting the long paragraph about open source and no commercial services into separate lines/paragraphs) to keep structure consistent across languages.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please double-check that the terms used for the settings section ("Normal Config", "普通配置", "Обычная конфигурация") exactly match the current UI labels so users can easily find where to disable metrics collection.
- In the Russian notice, consider aligning formatting with the other locales (e.g., splitting the long paragraph about open source and no commercial services into separate lines/paragraphs) to keep structure consistent across languages.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a notice regarding usage statistics collection to the English and Chinese versions of the FIRST_NOTICE file and introduces a new Russian translation of the notice. The review feedback identifies that the term "anonymous" is technically inaccurate as the system collects hostnames, which may contain identifiable information; it is suggested to either remove hostname collection or update the description to "non-sensitive usage statistics" to maintain accuracy.
Contributor
Author
|
改改 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7946 正在为 WebUI 添加禁用此功能的配置选项,本 PR 依赖 #7946 合并。
Modifications / 改动点
修改 FIRST_NOTICE.md:添加说明(中文)
修改 FIRST_NOTICE.en-US.md:添加说明(英文)
新增 FIRST_NOTICE.ru-RU.md:新增俄语版首次提示。
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Document anonymous usage metrics collection and add a Russian version of the first-run notice.
Documentation: