Skip to content

Feat/add metrics notice to first notice#7954

Closed
lingyun14beta wants to merge 3 commits intoAstrBotDevs:masterfrom
lingyun14beta:feat/add-metrics-notice-to-first-notice
Closed

Feat/add metrics notice to first notice#7954
lingyun14beta wants to merge 3 commits intoAstrBotDevs:masterfrom
lingyun14beta:feat/add-metrics-notice-to-first-notice

Conversation

@lingyun14beta
Copy link
Copy Markdown
Contributor

@lingyun14beta lingyun14beta commented May 2, 2026

#7946 正在为 WebUI 添加禁用此功能的配置选项,本 PR 依赖 #7946 合并。

Modifications / 改动点

修改 FIRST_NOTICE.md:添加说明(中文)
修改 FIRST_NOTICE.en-US.md:添加说明(英文)
新增 FIRST_NOTICE.ru-RU.md:新增俄语版首次提示。

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

image

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Document anonymous usage metrics collection and add a Russian version of the first-run notice.

Documentation:

  • Update Chinese and English first-run notices to mention anonymous usage statistics collection and how to disable it.
  • Add a Russian localized first-run notice including usage, licensing, and metrics information.

@auto-assign auto-assign Bot requested review from LIghtJUNction and Raven95676 May 2, 2026 09:30
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 2, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Please double-check that the terms used for the settings section ("Normal Config", "普通配置", "Обычная конфигурация") exactly match the current UI labels so users can easily find where to disable metrics collection.
  • In the Russian notice, consider aligning formatting with the other locales (e.g., splitting the long paragraph about open source and no commercial services into separate lines/paragraphs) to keep structure consistent across languages.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Please double-check that the terms used for the settings section ("Normal Config", "普通配置", "Обычная конфигурация") exactly match the current UI labels so users can easily find where to disable metrics collection.
- In the Russian notice, consider aligning formatting with the other locales (e.g., splitting the long paragraph about open source and no commercial services into separate lines/paragraphs) to keep structure consistent across languages.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a notice regarding usage statistics collection to the English and Chinese versions of the FIRST_NOTICE file and introduces a new Russian translation of the notice. The review feedback identifies that the term "anonymous" is technically inaccurate as the system collects hostnames, which may contain identifiable information; it is suggested to either remove hostname collection or update the description to "non-sensitive usage statistics" to maintain accuracy.

Comment thread FIRST_NOTICE.en-US.md
Comment thread FIRST_NOTICE.md
Comment thread FIRST_NOTICE.ru-RU.md
@lingyun14beta
Copy link
Copy Markdown
Contributor Author

改改

@lingyun14beta
Copy link
Copy Markdown
Contributor Author

#7955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant