Skip to content

Fix NullReferenceException in CssPeriodicValue #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianRappl merged 1 commit into from
May 11, 2026
Merged

Fix NullReferenceException in CssPeriodicValue #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions src/AngleSharp.Css.Tests/Styling/CssSheet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,76 @@ public void CssSheetSerializeBorder1pxSolidWithColor()
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderSideThenBorderAll1()
{
var cssSrc = "#rule1 { border-top: none; border: 1px solid #BBCCEB }";
var expected = "#rule1 { border: 1px solid rgba(187, 204, 235, 1) }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderSideThenBorderAll2()
{
var cssSrc = "#rule1 { border-top: none !important; border: 1px solid #BBCCEB }";
var expected = "#rule1 { border-top: none !important; border-right: 1px solid rgba(187, 204, 235, 1); border-bottom: 1px solid rgba(187, 204, 235, 1); border-left: 1px solid rgba(187, 204, 235, 1) }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderSideThenBorderAll3()
{
var cssSrc = "#rule1 { border-top: none; border: 1px solid #BBCCEB !important }";
var expected = "#rule1 { border: 1px solid rgba(187, 204, 235, 1) !important }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderSideThenBorderAll4()
{
var cssSrc = "#rule1 { border-top: none !important; border: 1px solid #BBCCEB !important }";
var expected = "#rule1 { border: 1px solid rgba(187, 204, 235, 1) !important }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderAllThenBorderSide1()
{
var cssSrc = "#rule1 { border: 1px solid #BBCCEB !important; border-top: none }";
var expected = "#rule1 { border: 1px solid rgba(187, 204, 235, 1) !important }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderAllThenBorderSide2()
{
var cssSrc = "#rule1 { border: 1px solid #BBCCEB; border-top: none !important }";
var expected = "#rule1 { border-top: none !important; border-right: 1px solid rgba(187, 204, 235, 1); border-bottom: 1px solid rgba(187, 204, 235, 1); border-left: 1px solid rgba(187, 204, 235, 1) }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBorderAllThenBorderSide3()
{
var cssSrc = "#rule1 { border: 1px solid #BBCCEB !important; border-top: none !important }";
var expected = "#rule1 { border-top: none !important; border-right: 1px solid rgba(187, 204, 235, 1) !important; border-bottom: 1px solid rgba(187, 204, 235, 1) !important; border-left: 1px solid rgba(187, 204, 235, 1) !important }";
var stylesheet = ParseStyleSheet(cssSrc);
var cssText = stylesheet.ToCss();
Assert.AreEqual(expected, cssText);
}

[Test]
public void CssSheetSerializeBackgroundWithUrlPositionRepeatX()
{
Expand Down
9 changes: 8 additions & 1 deletion src/AngleSharp.Css/Values/Multiples/CssPeriodicValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,14 @@ public String CssText

for (var i = 0; i < l; i++)
{
parts[i] = _values[i].CssText;
var value = _values[i];

if (value is null)
{
return String.Empty;
}

parts[i] = value.CssText;
}

if (l == 4 && parts[3].Is(parts[1]))
Expand Down
Loading