Fix NullReferenceException in CssPeriodicValue#214
Merged
Conversation
CssPeriodicValue.CssText throws if any of the items in _values array is null. This change makes CssText return an empty string if a null value is found during the iteration.
|
|
FlorianRappl
approved these changes
May 11, 2026
Contributor
FlorianRappl
left a comment
FlorianRappl
left a comment
There was a problem hiding this comment.
LGTM - thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
CssPeriodicValue.CssTextthrows if any of the items in_valuesarray is null. This change makesCssTextgetter return an empty string if a null value is found during the iteration.Fixes #213