Fix pulse time#93
Open
micahwoodard wants to merge 8 commits into
Open
Conversation
Collaborator
Author
bruno-f-cruz
requested changes
Jun 10, 2026
bruno-f-cruz
left a comment
Member
There was a problem hiding this comment.
I think if we are doing this, we may as well future-proof it and have "SetRightRewardAmount" be a Tuple<Bool, float> similar to SetIsRightValveMs. Once we do that, SetIsRightValveMs will become private to the OperationControl scope (currently a global subject shared with the UI components) and the flush will instead use the SetRightRewardAmount, which becomes the public interface. The advantage is that it gives an obvious interface to implement single-trial-level reward amount modification in the future, should we need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes bug where reward time is not reset after flushing valves. Now, reward time is reset after spouts are flushed. Confirmed that after flushing, reward amount returns to reward volume.