Skip to content

Fix pulse time#93

Open
micahwoodard wants to merge 8 commits into
mainfrom
fix-pulse-time
Open

Fix pulse time#93
micahwoodard wants to merge 8 commits into
mainfrom
fix-pulse-time

Conversation

@micahwoodard

Copy link
Copy Markdown
Collaborator

Fixes bug where reward time is not reset after flushing valves. Now, reward time is reset after spouts are flushed. Confirmed that after flushing, reward amount returns to reward volume.

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

Updated the workflow to have a SetRightRewardAmount subject to trigger calculation of reward. Sets right and left in init and controlled independently in calibration
image

@bruno-f-cruz bruno-f-cruz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we are doing this, we may as well future-proof it and have "SetRightRewardAmount" be a Tuple<Bool, float> similar to SetIsRightValveMs. Once we do that, SetIsRightValveMs will become private to the OperationControl scope (currently a global subject shared with the UI components) and the flush will instead use the SetRightRewardAmount, which becomes the public interface. The advantage is that it gives an obvious interface to implement single-trial-level reward amount modification in the future, should we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants