modernize build with proper install/export and metadata#24
Merged
Conversation
Contributor
|
Hi there! Thank you so much for putting together this PR and for contributing to the project. We really appreciate your time and effort! This PR packs quite a few changes, so I've broken down my thoughts into a few categories: 👍 What I agree with & find necessary
👌 What looks fine / harmless to me
🤔 Concerns & Suggested Adjustments
📉 Not recommended / Non-best practices
💡 General Suggestions moving forward
Let me know what you think! Thanks again for your contribution. |
The library could not be discovered via find_package() or installed, making it hard to integrate into real projects. Add full install pipeline (target export, Config.cmake, ConfigVersion.cmake) gated behind PROJECT_IS_TOP_LEVEL, so it works as both a standalone project and a FetchContent subdirectory without side effects.
Contributor
Author
|
Please take another look when you have a moment. Thanks. |
- Remove the custom test main boilerplate in favor of Catch2::Catch2WithMain. - Add LANGUAGES CXX and PRIVATE linkage visibility to all test targets for correctness.
X1aomu
approved these changes
Jun 24, 2026
Contributor
|
@ComixHe Should we bump the version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library currently lacks install and find_package() support, making it difficult to consume via CMake's standard package management. Downstream projects must manually set up include directories, and there is no version metadata for dependency resolution.