Conversation
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
Add README.md files for @zenstackhq/client-helpers, @zenstackhq/fetch-client, and @zenstackhq/tanstack-query so the packages have a description on npm. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @ymc9's task —— View job PR Review: merge dev to main (v3.7.2)
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR releases v3.7.2: adds E.164 phone-number validation (language attribute, isPhone rule, Zod mapping, tests), updates GitHub Actions publish workflow for OIDC/provenance, adds client READMEs, and bumps workspace package versions to 3.7.2. ChangesPhone Validation Feature and Release v3.7.2
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/zod/src/types.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/zod/test/factory.test.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
17-17:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPin
packageManagertopnpm@10.12.1.
package.jsoncurrently sets"packageManager": "pnpm@10.33.0"(line 17), conflicting with the repo guideline to pinpnpm@10.12.1. Update that field topnpm@10.12.1.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 17, Update the packageManager field in package.json from "pnpm@10.33.0" to the pinned version "pnpm@10.12.1"; locate the packageManager entry in package.json (the "packageManager" key) and replace its value so it matches the repository guideline.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/clients/fetch-client/README.md`:
- Line 3: Update the package description sentence in
packages/clients/fetch-client/README.md that currently reads "auto CRUD API" to
use the hyphenated compound modifier "auto-CRUD API"; locate the string in the
README (the top paragraph describing the fetch-based client) and replace the
unhyphenated phrase with "auto-CRUD API" so the user-facing docs use correct
grammar.
---
Outside diff comments:
In `@package.json`:
- Line 17: Update the packageManager field in package.json from "pnpm@10.33.0"
to the pinned version "pnpm@10.12.1"; locate the packageManager entry in
package.json (the "packageManager" key) and replace its value so it matches the
repository guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 63edb4fe-7b2c-4692-b596-1479f99f39a3
📒 Files selected for processing (38)
.github/workflows/publish-release.ymlpackage.jsonpackages/auth-adapters/better-auth/package.jsonpackages/cli/package.jsonpackages/cli/test/db/pull.test.tspackages/clients/client-helpers/README.mdpackages/clients/client-helpers/package.jsonpackages/clients/fetch-client/README.mdpackages/clients/fetch-client/package.jsonpackages/clients/tanstack-query/README.mdpackages/clients/tanstack-query/package.jsonpackages/common-helpers/package.jsonpackages/config/eslint-config/package.jsonpackages/config/tsdown-config/package.jsonpackages/config/typescript-config/package.jsonpackages/config/vitest-config/package.jsonpackages/create-zenstack/package.jsonpackages/ide/vscode/package.jsonpackages/language/package.jsonpackages/language/res/stdlib.zmodelpackages/orm/package.jsonpackages/plugins/policy/package.jsonpackages/schema/package.jsonpackages/sdk/package.jsonpackages/server/package.jsonpackages/testtools/package.jsonpackages/zod/package.jsonpackages/zod/src/utils.tspackages/zod/test/factory.test.tspackages/zod/test/schema/schema.tspackages/zod/test/schema/schema.zmodelsamples/orm/package.jsontests/e2e/orm/validation/custom-validation.test.tstests/e2e/orm/validation/toplevel.test.tstests/e2e/package.jsontests/regression/package.jsontests/runtimes/bun/package.jsontests/runtimes/edge-runtime/package.json
Contributor
|
Claude finished @ymc9's task —— View job PR Review: merge dev to main (v3.7.2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
@phonestring attribute and corresponding validation rule.Documentation
Tests
Chores