fix: Support single-level packages in runnables#254
Open
fredyw wants to merge 1 commit into
Open
Conversation
The tree-sitter query for runnables was only capturing `scoped_identifier` for package names. This caused it to completely miss single-level packages, e.g., `package example;`, which are parsed as a basic `identifier`. This updates the query to match both `identifier` and `scoped_identifier`.
|
We require contributors to sign our Contributor License Agreement, and we don't have @fredyw on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Collaborator
|
@fredyw thanks for the contribution. Could you expand the description explaining all the additions included in the PR? |
Collaborator
|
Consider also to extend the PR covering what #248 does for files without a package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree-sitter query for runnables was only capturing
scoped_identifierfor package names. This caused it to completely miss single-level packages, e.g.,package example;, which are parsed as a basicidentifier.This updates the query to match both
identifierandscoped_identifier.