Skip to content

Comments

TEST: fix group selection for delete#3707

Merged
dcherian merged 5 commits intozarr-developers:mainfrom
ianhi:fix/stateful-delete-group-precondition
Feb 21, 2026
Merged

TEST: fix group selection for delete#3707
dcherian merged 5 commits intozarr-developers:mainfrom
ianhi:fix/stateful-delete-group-precondition

Conversation

@ianhi
Copy link
Contributor

@ianhi ianhi commented Feb 12, 2026

Fix stateful test delete group precondition. This was excluding any groups at the root level, which can lead to a hypothesis error if you have these three groups /, 0, 1 because all of those were being excluded. the root group is nver in all_groups so this change should be safe to just select from all of them.

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 12, 2026
@ianhi
Copy link
Contributor Author

ianhi commented Feb 12, 2026

small correciton. root should never be there, but nothign was explcitly disallowing. so i updated the sampling to preclude it.

@d-v-b d-v-b requested a review from dcherian February 13, 2026 08:49
@ianhi ianhi force-pushed the fix/stateful-delete-group-precondition branch from e3c4e44 to 20ab882 Compare February 20, 2026 17:15
@dcherian dcherian merged commit efed3a4 into zarr-developers:main Feb 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants