Add cluster_labels and annotations to logical backup CronJob and Jobs#3085
Open
raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
Open
Add cluster_labels and annotations to logical backup CronJob and Jobs#3085raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
Conversation
When using the logical backup feature, the CronJob and its created Jobs were missing the cluster_labels and annotations that are applied to other cluster resources. This made it difficult to filter or identify backup jobs using the same labels as other cluster components. Changes: - Added ObjectMeta with labels and annotations to JobTemplateSpec - Updated CronJob ObjectMeta to use the merged labels (including 'application: spilo-logical-backup') - Updated tests to expect the new labels Fixes zalando#1834
raphaeltorquat0
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
mikkeloscar and
sdudoladov
as code owners
Author
|
Hi! Could a maintainer please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When using the logical backup feature, the CronJob and its created Jobs were missing the
cluster_labelsand annotations that are applied to other cluster resources like Pods, StatefulSets, and Services.This made it difficult to filter or identify backup jobs using the same labels as other cluster components.
Fixes #1834
Changes
ObjectMetawith labels and annotations toJobTemplateSpec, so Jobs created by the CronJob inherit the cluster labelsObjectMetato use the merged labels (includingapplication: spilo-logical-backup)Example
Before this fix, a logical backup CronJob would only have:
After this fix:
Type of change
Note: parts of this implementation were developed with AI assistance.