fix(trunk): remove stale sh-hook action blocking local git hooks#447
Open
ss-o wants to merge 1 commit into
Open
fix(trunk): remove stale sh-hook action blocking local git hooks#447ss-o wants to merge 1 commit into
ss-o wants to merge 1 commit into
Conversation
The sh-hook action ran .github/hook.sh on the pre-commit and pre-push git hooks, but that script was deleted in e3fd962, so every commit and push in clones with trunk-managed hooks failed with "sh-hook: line 1: .github/hook.sh: No such file or directory". Remove the action from actions.enabled and actions.definitions; the script only ran 'trunk check --show-existing', which the built-in trunk actions already cover when desired. Closes #445
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a stale Trunk custom git-hook action (sh-hook) from .trunk/trunk.yaml so local git commit/git push aren’t blocked by a missing .github/hook.sh script (per #445).
Changes:
- Drop
sh-hookfromactions.enabled. - Remove the
sh-hookcustom action definition fromactions.definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.trunk/trunk.yamlenables a customsh-hookaction that runs.github/hook.shon thepre-commitandpre-pushgit hooks, but that script was deleted in e3fd962. Everygit commit/git pushin a local clone with trunk-managed hooks fails:Fix
Remove the
sh-hookentry from bothactions.enabledandactions.definitions. The deleted script only rantrunk check --show-existing --no-progress, which trunk's built-intrunk-check-pre-push/trunk-fmt-pre-commitactions already provide when desired (both are deliberately disabled in this config).Closes #445
🤖 Generated with Claude Code