Allow lookup template attributes from globalTemplateAttributes#1400
Open
vikage wants to merge 9 commits intoyonaskolb:masterfrom
Open
Allow lookup template attributes from globalTemplateAttributes#1400vikage wants to merge 9 commits intoyonaskolb:masterfrom
vikage wants to merge 9 commits intoyonaskolb:masterfrom
Conversation
Author
|
@yonaskolb @brentleyjones Please help me review this PR |
Author
|
@yonaskolb Please help me review this PR. Thanks |
Owner
|
I can see the utility in this @vikage. Got a few notes:
|
Author
If you are agree with this feature, I will implement an example and some unit tests |
Owner
|
Yes happy for you to move it forward, with the ability to reference these values anywhere and not just within templates |
Author
|
@yonaskolb I added unit test and example. Please help me review. |
Author
|
@yonaskolb Please help me take a look |
Author
|
@yonaskolb Please review, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allow xcodegen to lookup template attributes from
globalTemplateAttributesspec to share attributes accross all yaml files.For example here, we have a shared today-extension-target.yml between multi project specs: legacy-project.yml and new-project.yml
We need to configure different config files between legacy and old. With this PR we just declare a
versionattribute from project spec andtoday-extension-target.ymlcan access itExample
today-extension-target.yml
legacy-project.yml
new-project.yml