automatic compilation and github releases#86
Open
AcrylonitrileButadieneStyrene wants to merge 6 commits intoynoproject:masterfrom
Open
automatic compilation and github releases#86AcrylonitrileButadieneStyrene wants to merge 6 commits intoynoproject:masterfrom
AcrylonitrileButadieneStyrene wants to merge 6 commits intoynoproject:masterfrom
Conversation
Desdaemon
reviewed
Apr 21, 2026
Comment on lines
+21
to
+23
| RUN autoreconf -fi | ||
| RUN bash -c "source /root/workdir/buildscripts/emscripten/emsdk-portable/emsdk_env.sh; \ | ||
| emconfigure ./configure --prefix=/root/workdir/buildscripts/emscripten --disable-shared" |
Contributor
There was a problem hiding this comment.
liblcf could be built with cmake instead
| docker run -v $(pwd):/root/workdir/ynoengine:rw -e PLAYER_PSK="${{ secrets.PSK }}" ghcr.io/${REPO,,}:master | ||
| docker run -v $(pwd):/root/workdir/ynoengine:rw -e PLAYER_PSK="${{ secrets.PSK }}" -e NO_SIMD=1 ghcr.io/${REPO,,}:master | ||
| echo "TAG=$(date +'%Y-%m-%d.%H.%M.%S')" >> $GITHUB_ENV | ||
| - uses: softprops/action-gh-release@v3 |
Contributor
There was a problem hiding this comment.
since we most likely build local then deploy straight to server this step is probably not needed; could provide instructions to build local instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a docker file for setting up the build tools, when ran acts like a compiler (source is passed in with -v)
adds configuring the PSK through an env var (which can be passed into docker with -e)
unrelated changes:
after merge setup steps:
PSK, including the braces around the bytes