-
-
Notifications
You must be signed in to change notification settings - Fork 30
Introduce message class resolver #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vjik
wants to merge
3
commits into
master
Choose a base branch
from
message-class-resolver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Queue\Message\ClassResolver; | ||
|
|
||
| use Yiisoft\Queue\Message\MessageInterface; | ||
|
|
||
| /** | ||
| * Resolves message classes from a predefined map of type-to-class associations. | ||
| */ | ||
| final class ArrayMessageClassResolver implements MessageClassResolverInterface | ||
| { | ||
| /** | ||
| * @param array $map Map of message type to message class, where keys are message types and values are | ||
| * fully-qualified class names implementing {@see MessageInterface}. For example: | ||
| * | ||
| * ```php | ||
| * [ | ||
| * 'order.created' => OrderCreatedMessage::class, | ||
| * 'send_email' => SendEmailMessage::class, | ||
| * ] | ||
| * ``` | ||
| * | ||
| * @psalm-param array<string, class-string<MessageInterface>> $map | ||
| */ | ||
| public function __construct( | ||
| private readonly array $map = [], | ||
| ) {} | ||
|
|
||
| public function resolve(string $type): ?string | ||
| { | ||
| return $this->map[$type] ?? null; | ||
| } | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
src/Message/ClassResolver/MessageClassResolverInterface.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Queue\Message\ClassResolver; | ||
|
|
||
| use Yiisoft\Queue\Message\MessageInterface; | ||
|
|
||
| /** | ||
| * Resolves a message class by message type. | ||
| */ | ||
| interface MessageClassResolverInterface | ||
| { | ||
| /** | ||
| * Returns the message class for the given type, or `null` if the type is not registered. | ||
| * | ||
| * @param string $type Message type. | ||
| * | ||
| * @return string|null Message class, or `null` if the type is not registered. | ||
| * | ||
| * @psalm-return class-string<MessageInterface>|null | ||
| */ | ||
| public function resolve(string $type): ?string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
tests/Unit/Message/ClassResolver/ArrayMessageClassResolverTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Queue\Tests\Unit\Message\ClassResolver; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Yiisoft\Queue\Message\ClassResolver\ArrayMessageClassResolver; | ||
| use Yiisoft\Queue\Message\GenericMessage; | ||
| use Yiisoft\Queue\Tests\Unit\Support\TestMessage; | ||
|
|
||
| final class ArrayMessageClassResolverTest extends TestCase | ||
| { | ||
| public function testResolveRegisteredType(): void | ||
| { | ||
| $resolver = new ArrayMessageClassResolver(['test' => TestMessage::class]); | ||
|
|
||
| $this->assertSame(TestMessage::class, $resolver->resolve('test')); | ||
| } | ||
|
|
||
| public function testResolveUnregisteredTypeReturnsNull(): void | ||
| { | ||
| $resolver = new ArrayMessageClassResolver(['test' => TestMessage::class]); | ||
|
|
||
| $this->assertNull($resolver->resolve('unknown')); | ||
| } | ||
|
|
||
| public function testResolveWithEmptyMapReturnsNull(): void | ||
| { | ||
| $resolver = new ArrayMessageClassResolver(); | ||
|
|
||
| $this->assertNull($resolver->resolve('test')); | ||
| } | ||
|
|
||
| public function testResolveMultipleTypes(): void | ||
| { | ||
| $resolver = new ArrayMessageClassResolver([ | ||
| 'generic' => GenericMessage::class, | ||
| 'test' => TestMessage::class, | ||
| ]); | ||
|
|
||
| $this->assertSame(GenericMessage::class, $resolver->resolve('generic')); | ||
| $this->assertSame(TestMessage::class, $resolver->resolve('test')); | ||
| $this->assertNull($resolver->resolve('not-registered')); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other implementations do you see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Search by attribute.