Validate DEV_USER_EXTENSIONS_PATH in utility function to prevent activation failures#23
Validate DEV_USER_EXTENSIONS_PATH in utility function to prevent activation failures#23Copilot wants to merge 7 commits intofeat/dev-env-variablesfrom
Conversation
Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
yCodeTech
left a comment
There was a problem hiding this comment.
A lot of this validation and errors should probably go in the util function that adds it to the env in the first place.
Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
Moved the validation logic from Addressed in commit 88864fe. |
Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
yCodeTech
left a comment
There was a problem hiding this comment.
Hmm. Maybe it should be in a new util function for validation? Because of the DOT principle.
…nciple Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
Created a separate Addressed in commit 64f50b5. |
yCodeTech
left a comment
There was a problem hiding this comment.
Why is this above the addDevEnvVariables? Please move it below for better organisation.
Co-authored-by: yCodeTech <31927084+yCodeTech@users.noreply.github.com>
Moved Addressed in commit 25e5e94. |
- Added `validateDevEnvVariables` util function to validate and sanitize the `DEV_USER_EXTENSIONS_PATH` env variable value. Added it's function call to `addDevEnvVariables` util function. This function is based on the code Copilot created in PR #23, but with significant improvement.
|
Superseded by #24. |
- Added `validateDevEnvVariables` util function to validate and sanitize the `DEV_USER_EXTENSIONS_PATH` env variable value. Added it's function call to `addDevEnvVariables` util function. This function is based on the code Copilot created in PR #23, but with significant improvement.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.